From: Joerg Roedel <joro@8bytes.org>
To: Torsten Kaiser <just.for.lkml@googlemail.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Linus Torvalds <torvalds@linux-foundation.org>,
mingo@elte.hu, lethal@linux-sh.org, hancockrwd@gmail.com,
jens.axboe@oracle.com, bharrosh@panasas.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] dma-debug: disable DMA_API_DEBUG for now
Date: Sat, 13 Jun 2009 13:10:14 +0200 [thread overview]
Message-ID: <20090613111014.GA18638@8bytes.org> (raw)
In-Reply-To: <64bb37e0906120751u14cac347hfa2356372e1e0a6a@mail.gmail.com>
On Fri, Jun 12, 2009 at 04:51:01PM +0200, Torsten Kaiser wrote:
> On Fri, Jun 12, 2009 at 4:13 PM, Joerg Roedel<joerg.roedel@amd.com> wrote:
> > On Thu, Jun 11, 2009 at 07:38:47PM +0200, Torsten Kaiser wrote:
> >> DMA-API: device driver tries to free DM
> >> A memory it has not allocated [device address=0x000000011e4c3000]
> >> [size=4096 bytes]
> >
> > Hmm, looking again over the code I've seen that the ref
> > dma_debug_entries are not alway filled with all necessary information
> > for best-fit. Can you please try if you still get false warnings when
> > you apply the two patches attached instead of the one I sent yesterday?
>
> Hmm... There isn't a get_nr_mapped_entries() in 2.6.30.
> Are these patches again the current linus tree?
Indeed. These patches are against tip/core/iommu but should also apply
against current linus/master too.
> For unfilled information I wanted to complain that for non-sg mapping
> sg_call_ents never gets filled. But as dma_entry_alloc() does a
> memset() to clean the entrys it should not matter.
> And what about dma_debug_entry.paddr? Should this also be compared?
paddr shouldn't matter. We also can't compare against it because it is
not a parameter we get in the unmap path (not always).
Joerg
next prev parent reply other threads:[~2009-06-13 11:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 8:33 [PATCH] dma-debug: disable DMA_API_DEBUG for now FUJITA Tomonori
2009-06-05 10:41 ` Joerg Roedel
2009-06-05 11:38 ` FUJITA Tomonori
2009-06-05 12:44 ` Joerg Roedel
2009-06-05 14:57 ` Arnd Bergmann
2009-06-05 15:52 ` Torsten Kaiser
2009-06-05 18:20 ` Joerg Roedel
2009-06-05 20:25 ` Torsten Kaiser
2009-06-05 22:11 ` Torsten Kaiser
2009-06-07 8:13 ` Ingo Molnar
2009-06-07 8:22 ` Torsten Kaiser
2009-06-07 10:45 ` FUJITA Tomonori
2009-06-07 10:22 ` [tip:core/iommu] dma-debug: change hash_bucket_find from first-fit to best-fit tip-bot for Joerg Roedel
2009-06-10 20:41 ` [PATCH] dma-debug: disable DMA_API_DEBUG for now Torsten Kaiser
2009-06-11 8:10 ` Joerg Roedel
2009-06-11 17:38 ` Torsten Kaiser
2009-06-12 7:50 ` Joerg Roedel
2009-06-12 14:13 ` Joerg Roedel
2009-06-12 14:51 ` Torsten Kaiser
2009-06-13 11:10 ` Joerg Roedel [this message]
2009-06-13 14:26 ` Torsten Kaiser
2009-06-13 17:34 ` Joerg Roedel
2009-06-13 17:08 ` Torsten Kaiser
2009-06-15 7:46 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090613111014.GA18638@8bytes.org \
--to=joro@8bytes.org \
--cc=bharrosh@panasas.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hancockrwd@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=joerg.roedel@amd.com \
--cc=just.for.lkml@googlemail.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox