From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org, Michael Chan <mchan@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: -git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declaration of function ‘__symbol_get’
Date: Sat, 13 Jun 2009 22:31:00 +0200 [thread overview]
Message-ID: <20090613203100.GA14294@elte.hu> (raw)
In-Reply-To: <alpine.LFD.2.01.0906131309560.3237@localhost.localdomain>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > --- a/drivers/net/cnic.c
> > +++ b/drivers/net/cnic.c
> > @@ -25,6 +25,8 @@
> > #include <linux/delay.h>
> > #include <linux/ethtool.h>
> > #include <linux/if_vlan.h>
> > +#include <linux/module.h>
> > +
>
> That makes no sense.
>
> Look at the first #include in the file - it already includes
> <linux/module.h>.
>
> Why do we need to do it twice?
Hm, indeed ... weird - i pasted that error message from a direct
reproducer and when i added module.h the build failure disappeared.
James - please discard the second patch for now, there's something
fishy here.
I tried to reproduce this second problem with the configs i
saved/sent and failed. I'll now started tests with just Randy's fix.
Ingo
next prev parent reply other threads:[~2009-06-13 21:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 18:43 -git tree build failure in drivers/net/cnic.c: undefined reference to `ip6_route_output' Ingo Molnar
2009-06-12 18:43 ` Randy Dunlap
2009-06-12 23:51 ` David Miller
2009-06-13 0:03 ` James Bottomley
2009-06-13 0:05 ` David Miller
2009-06-13 14:37 ` James Bottomley
2009-06-13 6:42 ` Ingo Molnar
2009-06-13 7:03 ` Michael Chan
2009-06-13 6:29 ` -git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declaration of function ‘__symbol_get’ Ingo Molnar
2009-06-13 20:11 ` Linus Torvalds
2009-06-13 20:31 ` Ingo Molnar [this message]
2009-06-13 20:35 ` Ingo Molnar
2009-06-13 20:46 ` Ingo Molnar
2009-06-13 20:42 ` James Bottomley
2009-06-14 0:43 ` Michael Chan
2009-06-14 1:33 ` James Bottomley
2009-06-14 2:18 ` Michael Chan
2009-06-14 14:15 ` James Bottomley
2009-06-14 14:51 ` -git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declaration of function '__symbol_get' Michael Chan
2009-06-15 1:27 ` -git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declaration of function ‘__symbol_get’ Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090613203100.GA14294@elte.hu \
--to=mingo@elte.hu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=randy.dunlap@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox