From: Rusty Russell <rusty@rustcorp.com.au>
To: Tony Luck <tony.luck@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Amerigo Wang <amwang@redhat.com>,
alex@shark-linux.de, David Miller <davem@davemloft.net>,
rth@twiddle.net, sfr@canb.auug.org.au
Subject: Re: [PULL] module and parameter
Date: Sat, 13 Jun 2009 21:35:31 +0930 [thread overview]
Message-ID: <200906132135.32552.rusty@rustcorp.com.au> (raw)
In-Reply-To: <200906131450.16211.rusty@rustcorp.com.au>
On Sat, 13 Jun 2009 02:50:15 pm Rusty Russell wrote:
> On Sat, 13 Jun 2009 06:35:46 am Tony Luck wrote:
> > On Fri, Jun 12, 2009 at 5:35 AM, Rusty Russell<rusty@rustcorp.com.au> wrote:
> > > module: trim exception table on init free.
> >
> > This is causing build errors for ia64:
Unfortunately this has gone into Linus' tree already. I have compile-tested
my previous patch for ia64, and it fixes compile at least.
> > I note that this commit has been reverted in linux-next. What's going
> > on?
kisskb.ellerman.id.au says it's broken there, so it's applied.
While I've got your attention, there was another build break on ia64 in
linux-next, caused by removal of smp_call_function_mask.
Thanks,
Rusty.
Subject: ia64: convert last user of smp_call_function_mask
smp_call_function_many is the new version: it takes a pointer. Also,
use mm accessor macro while we're changing this.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff --git a/arch/ia64/kernel/smp.c b/arch/ia64/kernel/smp.c
--- a/arch/ia64/kernel/smp.c
+++ b/arch/ia64/kernel/smp.c
@@ -301,7 +301,7 @@ smp_flush_tlb_mm (struct mm_struct *mm)
return;
}
- smp_call_function_mask(mm->cpu_vm_mask,
+ smp_call_function_many(mm_cpumask(mm),
(void (*)(void *))local_finish_flush_tlb_mm, mm, 1);
local_irq_disable();
local_finish_flush_tlb_mm(mm);
next prev parent reply other threads:[~2009-06-13 12:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 12:35 [PULL] module and parameter Rusty Russell
2009-06-12 21:05 ` Tony Luck
2009-06-13 5:20 ` Rusty Russell
2009-06-13 12:05 ` Rusty Russell [this message]
2009-06-15 18:28 ` Luck, Tony
2009-06-15 18:10 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906132135.32552.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=alex@shark-linux.de \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
--cc=sfr@canb.auug.org.au \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox