Re: [PATCH 0/3] kbuild: some scripts/config improvements (try 2)

[Sam Ravnborg <sam@ravnborg.org>]

On Thu, Jun 04, 2009 at 07:47:08AM +0200, Michal Marek wrote:
> On Wed, Jun 03, 2009 at 10:16:46PM +0200, Andi Kleen wrote:
> > On Wed, Jun 03, 2009 at 09:25:20PM +0200, Sam Ravnborg wrote:
> > > On Mon, May 25, 2009 at 04:43:20PM +0200, Michal Marek wrote:
> > > > Hi,
> > > > 
> > > > I simplified the awk script a bit, made it awk ... && mv and removed the
> > > > --set option.
> > > > 
> > > > Michal Marek (3):
> > > >   kbuild: handle non-existing options in scripts/config
> > > >   kbuild: simplify argument loop in scripts/config
> > > >   kbuild: add generic --set-str option to scripts/config
> > > 
> > > Andi - do I have your ack on this serie?
> > 
> > Reluctantly -- most bits are ok, but the awk change seems quite overcomplicated
> > and I don't like it particularly.
> 
> What about this one? The other two patches apply apply at slightly
> different offsets.
> 
> Subject: [PATCH 1/3] kbuild: handle non-existing options in scripts/config
> 
> If an option does not exist in .config, set it at the end of the file.
> 
> Signed-off-by: Michal Marek <mmarek@suse.cz>

Looked readable - compared to the awk stuff.
I have applied all three patches.

	Sam