From: Paul Mundt <lethal@linux-sh.org>
To: Linus Walleij <linus.ml.walleij@gmail.com>
Cc: Tim Bird <tim.bird@am.sony.com>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
linux kernel <linux-kernel@vger.kernel.org>,
Russell King <rmk@arm.linux.org.uk>,
Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] ftrace,arm: add notrace to ARM sched_clock routines - resend
Date: Mon, 15 Jun 2009 06:30:49 +0900 [thread overview]
Message-ID: <20090614213049.GA15366@linux-sh.org> (raw)
In-Reply-To: <63386a3d0906141051v50cc441fj27f0132fa5c77b80@mail.gmail.com>
On Sun, Jun 14, 2009 at 07:51:04PM +0200, Linus Walleij wrote:
> 2009/6/13 Tim Bird <tim.bird@am.sony.com>:
>
> > Add notrace attribute to sched_clock, to avoid
> > recursion with ftrace function tracing.
> >
> > Signed-off-by: Tim Bird <tim.bird@am.sony.com>
> > ---
> > arch/arm/mach-mmp/time.c | 2 +-
> > arch/arm/mach-pxa/time.c | 2 +-
> > arch/arm/mach-realview/core.c | 2 +-
> > arch/arm/mach-sa1100/generic.c | 2 +-
> > arch/arm/mach-versatile/core.c | 2 +-
> > arch/arm/plat-omap/common.c | 4 ++--
> > 6 files changed, 7 insertions(+), 7 deletions(-)
>
> And now that Paul Mundt is making it possible to use the default
> sched_clock() with the generic clocksource and the OMAP hack
> will likely go away, should the default implementation in
> kernel/sched_clock.c also be tagged as
> unsigned long long notrace __attribute__((weak)) sched_clock(void)
> or something?
>
> Should it be tagged notrace even if it's the old jiffybased one even?
>
Thanks for pointing that out. Yes, the new generic version will need the
notrace attribute as well, I will include this in the next iteration.
prev parent reply other threads:[~2009-06-14 21:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 22:07 [PATCH] ftrace,arm: add notrace to ARM sched_clock routines - resend Tim Bird
2009-06-14 17:51 ` Linus Walleij
2009-06-14 21:30 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090614213049.GA15366@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rmk@arm.linux.org.uk \
--cc=rostedt@goodmis.org \
--cc=tim.bird@am.sony.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox