Re: [Patch BUGFIX] kcore: fix its wrong size on x86_64

Eric W. Biederman
2009-06-18T03:37:49Z

Amerigo Wang <xiyou.wangcong@gmail.com> writes:

> On Tue, Jun 16, 2009 at 12:27:36PM -0700, Eric W. Biederman wrote:
>>Américo Wang <xiyou.wangcong@gmail.com> writes:
>>>> I think a case can be made either way.  In practice neither answer
>>>> gives us a dense offset space on x86_64 so I think I prefer the
>>>> current definition which sets or clears the high bits as opposed
>>>> to something that mangles the address more.
>>>>
>>>
>>> I am trying to dig more... There must be something wrong there.
>>
>>How so?
>
> See what you will get for kc_vaddr_to_offset(__va(0))?
> It is supposed to be 0.

I see: 0x0000880000001000 That extra 0x1000 looks suspicous.

It MUST NOT be 0. That is where the ELF header lives in the file.

> Yes, I am cooking a patch set... will send them when ready.

The I will leave it to you.

Eric