Re: [Patch BUGFIX] kcore: fix its wrong size on x86_64

Eric W. Biederman
2009-06-15T10:11:13Z

Tao Ma <tao.ma@oracle.com> writes:

> Hi Amerigo,
>
> The wrong number I mean is 131941393240064.
>
> So do you think
> [root@test3 ~]# ls -l /proc/kcore
> -r-------- 1 root root 131941393240064 Jun 15 13:39 /proc/kcore
>
> is better than
>
> [taoma@test2 ~]$ ll /proc/kcore
> -r-------- 1 root root 281474974617600 Jun 15 15:20 /proc/kcore
> ?
>
> I don't think so.
>
> Actually the right result should look like
>
> [root@test8 ~]# ls -l /proc/kcore
> -r-------- 1 root root 5301604352 Jun 15 13:35 /proc/kcore
>
> And with your patch I can't get this number.

Actually that value is the bug. It has absolutely nothing
to do with the offsets that are valid within /proc/kcore.

Why do you prefer the smaller number?

Eric