From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755814AbZFOGVh (ORCPT ); Mon, 15 Jun 2009 02:21:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751898AbZFOGV2 (ORCPT ); Mon, 15 Jun 2009 02:21:28 -0400 Received: from one.firstfloor.org ([213.235.205.2]:34439 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbZFOGV1 (ORCPT ); Mon, 15 Jun 2009 02:21:27 -0400 Date: Mon, 15 Jun 2009 08:29:34 +0200 From: Andi Kleen To: Wu Fengguang Cc: Andrew Morton , LKML , Ingo Molnar , Mel Gorman , Thomas Gleixner , "H. Peter Anvin" , Peter Zijlstra , Nick Piggin , Hugh Dickins , Andi Kleen , "riel@redhat.com" , "chris.mason@oracle.com" , "linux-mm@kvack.org" Subject: Re: [PATCH 21/22] HWPOISON: send uevent to report memory corruption Message-ID: <20090615062934.GB31969@one.firstfloor.org> References: <20090615024520.786814520@intel.com> <20090615031255.278184860@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090615031255.278184860@intel.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2009 at 10:45:41AM +0800, Wu Fengguang wrote: > This allows the user space to do some flexible policies. > For example, it may either do emergency sync/shutdown > or to schedule reboot at some convenient time, depending > on the severeness of the corruption. > I don't think it's a good idea to export that much detailed information. That would become a stable ABI, but might not be possible to keep all these details stable. e.g. map count or reference count are internal implementation details that shouldn't be exposed. And what is an user space application to do with the inode? Run find -inum? Also we already report the event using low level logging mechanism. in a relatively stable form. It's also unclear to me what an application would do with that much detail. I would suggest to drop this part and the earlier flags move. Please only bug fixes are this stage. -Andi