From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [PATCH 4/7] tracing: replace a GFP_ATOMIC with GFP_KERNEL allocation
Date: Mon, 15 Jun 2009 17:58:50 +0200 [thread overview]
Message-ID: <20090615155850.GC19529@elte.hu> (raw)
In-Reply-To: <20090615154411.136115951@goodmis.org>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> From: Li Zefan <lizf@cn.fujitsu.com>
>
> Atomic allocation is not needed here.
>
> [ Impact: clean up of memory alloction type ]
Note, the impact line was probably not needed here - and if we add
one then the correct one would be:
[ Impact: use less failure-prone (non-atomic) allocations ]
Ingo
next prev parent reply other threads:[~2009-06-15 15:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 15:42 [PATCH 0/7] [GIT PULL] updates for 2.6.31 Steven Rostedt
2009-06-15 15:42 ` [PATCH 1/7] cpumask: use new operators in kernel/trace Steven Rostedt
2009-06-15 15:42 ` [PATCH 2/7] tracing: fix undeclared PAGE_SIZE in include/linux/trace_seq.h Steven Rostedt
2009-06-15 15:42 ` [PATCH 3/7] tracing: fix a typo in tracing_cpumask_write() Steven Rostedt
2009-06-15 15:42 ` [PATCH 4/7] tracing: replace a GFP_ATOMIC with GFP_KERNEL allocation Steven Rostedt
2009-06-15 15:58 ` Ingo Molnar [this message]
2009-06-15 15:42 ` [PATCH 5/7] tracing/filters: operand can be negative Steven Rostedt
2009-06-15 15:42 ` [PATCH 6/7] tracing/filters: strloc should be unsigned short Steven Rostedt
2009-06-15 15:42 ` [PATCH 7/7] ring-buffer: prevent adding write in discarded area Steven Rostedt
2009-06-15 15:56 ` [PATCH 0/7] [GIT PULL] updates for 2.6.31 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615155850.GC19529@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox