From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761649AbZFOP7G (ORCPT ); Mon, 15 Jun 2009 11:59:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753663AbZFOP64 (ORCPT ); Mon, 15 Jun 2009 11:58:56 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:57140 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753128AbZFOP6z (ORCPT ); Mon, 15 Jun 2009 11:58:55 -0400 Date: Mon, 15 Jun 2009 17:58:50 +0200 From: Ingo Molnar To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Andrew Morton , Frederic Weisbecker , Li Zefan Subject: Re: [PATCH 4/7] tracing: replace a GFP_ATOMIC with GFP_KERNEL allocation Message-ID: <20090615155850.GC19529@elte.hu> References: <20090615154226.058101204@goodmis.org> <20090615154411.136115951@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090615154411.136115951@goodmis.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt wrote: > From: Li Zefan > > Atomic allocation is not needed here. > > [ Impact: clean up of memory alloction type ] Note, the impact line was probably not needed here - and if we add one then the correct one would be: [ Impact: use less failure-prone (non-atomic) allocations ] Ingo