From: David Brownell <david-b@pacbell.net>
To: "Russell King - ARM Linux" <linux@arm.linux.org.uk>
Cc: Baruch Siach <baruch@tkos.co.il>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3] gpio: driver for PrimeCell PL061 GPIO controller
Date: Mon, 15 Jun 2009 16:38:04 -0700 [thread overview]
Message-ID: <200906151638.05008.david-b@pacbell.net> (raw)
In-Reply-To: <20090604092835.GJ29926@n2100.arm.linux.org.uk>
On Thursday 04 June 2009, Russell King - ARM Linux wrote:
> > +static unsigned int pl061_irq_startup(unsigned irq)
> > +{
> > + int ret;
> > +
> > + ret = gpio_request(irq_to_gpio(irq), "IRQ");
> > + if (ret < 0) {
> > + pr_warning("%s: warning: gpio_request(%d) returned %d\n",
> > + __func__, irq_to_gpio(irq), ret);
> > + return 0;
> > + }
> > +
> > + gpio_direction_input(irq_to_gpio(irq));
>
> I thought that it was not expected that claiming an interrupt would claim
> a GPIO automatically - in other words, it's the responsibility of the
> driver or platform itself to claim GPIOs for interrupts and ensure that
> they're properly configured.
You're right about that.
prev parent reply other threads:[~2009-06-15 23:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 20:48 [PATCH v3] gpio: driver for PrimeCell PL061 GPIO controller Baruch Siach
2009-06-02 23:09 ` Andrew Morton
2009-06-03 3:20 ` Baruch Siach
2009-06-04 9:28 ` Russell King - ARM Linux
2009-06-04 15:58 ` Baruch Siach
2009-06-15 23:38 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906151638.05008.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=baruch@tkos.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox