From: Oleg Nesterov <oleg@redhat.com>
To: Vitaly Mayatskikh <v.mayatskih@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] Use copy_wait_opts_to_user() in wait_task_zombie()
Date: Mon, 15 Jun 2009 18:43:24 +0200 [thread overview]
Message-ID: <20090615164324.GB7425@redhat.com> (raw)
In-Reply-To: <1242048349-2766-5-git-send-email-v.mayatskih@gmail.com>
On 05/11, Vitaly Mayatskikh wrote:
>
> @@ -1267,36 +1265,21 @@ static int wait_task_zombie(struct wait_opts *wo, struct task_struct *p)
> */
> read_unlock(&tasklist_lock);
>
> - retval = wo->wo_rusage
> - ? getrusage(p, RUSAGE_BOTH, wo->wo_rusage) : 0;
> status = (p->signal->flags & SIGNAL_GROUP_EXIT)
> ? p->signal->group_exit_code : p->exit_code;
> - if (!retval && wo->wo_stat)
> + if (wo->wo_stat)
> retval = put_user(status, wo->wo_stat);
We don't check retval, and then later
> [...snip...]
> + retval = copy_wait_opts_to_user(wo, p, pid, uid, why, status, SIGCHLD);
we overwrite it.
This needs a fix.
Oleg.
next prev parent reply other threads:[~2009-06-15 16:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 13:25 [PATCH 0/5] wait_task_* cleanups V2 Vitaly Mayatskikh
2009-05-11 13:25 ` [PATCH 1/5] Split wait_noreap_copyout() Vitaly Mayatskikh
2009-05-11 23:45 ` Andrew Morton
2009-05-20 15:21 ` Vitaly Mayatskikh
2009-05-20 15:57 ` Oleg Nesterov
2009-05-20 20:29 ` Roland McGrath
2009-05-20 18:21 ` Ingo Molnar
2009-05-21 14:12 ` Oleg Nesterov
2009-05-21 14:35 ` Vitaly Mayatskikh
2009-06-09 15:14 ` Vitaly Mayatskikh
2009-05-11 13:25 ` [PATCH 2/5] Use copy_wait_opts_to_user() in wait_task_stopped() Vitaly Mayatskikh
2009-05-11 13:25 ` [PATCH 3/5] Use copy_wait_opts_to_user() in do_wait() Vitaly Mayatskikh
2009-06-15 16:39 ` Oleg Nesterov
2009-05-11 13:25 ` [PATCH 4/5] Use copy_wait_opts_to_user() in wait_task_zombie() Vitaly Mayatskikh
2009-06-15 16:43 ` Oleg Nesterov [this message]
2009-05-11 13:25 ` [PATCH 5/5] Use copy_wait_opts_to_user() in wait_task_continued() Vitaly Mayatskikh
2009-06-15 16:55 ` Oleg Nesterov
2009-06-15 17:13 ` Oleg Nesterov
2009-06-15 17:16 ` Andrew Morton
2009-05-12 3:19 ` [PATCH 0/5] wait_task_* cleanups V2 Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615164324.GB7425@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=v.mayatskih@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox