Re: [PATCH 01/11] ext3: Get rid of extenddisksize parameter of ext3_get_blocks_handle()

Jan Kara
2009-06-17T11:49:52Z

On Wed 17-06-09 12:28:10, Nick Piggin wrote:
> On Mon, Jun 15, 2009 at 07:59:48PM +0200, Jan Kara wrote:
> > Get rid of extenddisksize parameter of ext3_get_blocks_handle(). This seems to
> > be a relict from some old days and setting disksize in this function does not
> > make much sence. Currently it was set only by ext3_getblk(). Since the
> > parameter has some effect only if create == 1, it is easy to check that the
> > three callers which end up calling ext3_getblk() with create == 1 (ext3_append,
> > ext3_quota_write, ext3_mkdir) do the right thing and set disksize themselves.
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
>
> I guess something like this should just go in this merge window if
> ext3 developers are happy with it? There is no real reason to keep
> it with the main patchset is there?
Yes, I'll merge this separately. It's in the series just because ext3
patches depend on it.

Honza

--
Jan Kara <jack@suse.cz>
SUSE Labs, CR