From: Arjan van de Ven <arjan@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Li Zefan" <lizf@cn.fujitsu.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Alan Cox" <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] WARN(): add a \n to the message printk
Date: Mon, 15 Jun 2009 22:46:28 -0700 [thread overview]
Message-ID: <20090615224628.7b0f096c@infradead.org> (raw)
In-Reply-To: <alpine.LFD.2.01.0906152055580.3282@localhost.localdomain>
On Mon, 15 Jun 2009 21:04:25 -0700 (PDT)
Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> And no, this does not necessarily fix Arjan's problem: it only adds
> the newline before printk's that _do_ have a KERN_<lvl> format. So
> now, in order to get the extra '\n' after the WARN_ON() line,
> somebody needs to make sure that the printk's in the warning printing
> have loglevels.
>
> Arjan?
>
I liked the first patch more :-) ... but practical considerations make
this one more useful I suppose. I'll make the warnings work.
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2009-06-16 5:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 7:08 [PATCH] WARN(): add a \n to the message printk Arjan van de Ven
2009-06-15 9:09 ` Alan Cox
2009-06-15 14:13 ` Arjan van de Ven
2009-06-15 16:38 ` Linus Torvalds
2009-06-15 16:58 ` Linus Torvalds
2009-06-15 17:10 ` Ingo Molnar
2009-06-16 4:04 ` Linus Torvalds
2009-06-16 4:16 ` Linus Torvalds
2009-06-16 5:46 ` Arjan van de Ven [this message]
2009-06-15 17:57 ` Linus Torvalds
2009-06-15 18:39 ` Ingo Molnar
2009-06-15 18:53 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615224628.7b0f096c@infradead.org \
--to=arjan@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox