From: Alek Du <alek.du@intel.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: Florian Fainelli <florian@openwrt.org>,
Ben Dooks <ben-linux@fluff.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: Add gpio_detect, gpio_debounce and gpio_alt_func features to GPIOLIB
Date: Tue, 16 Jun 2009 09:28:48 +0800 [thread overview]
Message-ID: <20090616092848.7bb60f21@dxy.sh.intel.com> (raw)
In-Reply-To: <20090615130906.GA14476@trinity.fluff.org>
On Mon, 15 Jun 2009 21:09:06 +0800
Ben Dooks <ben-linux@fluff.org> wrote:
> >
> > I would expect your architecture IRQ handler to have a set_type callback for
> > the GPIO lines capables of generating an interrupt. See how we have beeing
> > doing it for rb532 for instance:
> > http://www.linux-mips.org/git?p=linux-queue.git;a=blob;f=arch/mips/rb532/irq.c;h=f07882029a90d3d155c17b462812c2936229458c;hb=HEAD#l173
>
> Yes, or if the GPIO driver is exporting interrupts, the relevant handler
> for that chip should have the .set_type method defined.
>
In the .set_type method, you finally will call the GPIO driver's function to set interrupt trigger mode, right?
Current GPIOLIB do not provide such an interface. Current driver always exports a separate function to do that --
that's not good.
My patch provide a general API to do that.
Thanks,
Alek
next prev parent reply other threads:[~2009-06-16 1:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 9:15 [PATCH] gpiolib: Add gpio_detect, gpio_debounce and gpio_alt_func features to GPIOLIB Alek Du
2009-06-15 9:50 ` Ben Dooks
2009-06-15 10:02 ` Mark Brown
2009-06-15 11:19 ` Alek Du
2009-06-15 12:56 ` Florian Fainelli
2009-06-15 12:50 ` Ben Dooks
2009-06-15 13:07 ` Mark Brown
2009-06-15 11:29 ` Alek Du
2009-06-15 12:51 ` Ben Dooks
2009-06-15 13:04 ` Florian Fainelli
2009-06-15 13:09 ` Ben Dooks
2009-06-16 1:28 ` Alek Du [this message]
2009-06-16 8:39 ` Ben Dooks
2009-06-17 6:59 ` [PATCH v2] gpiolib: Add " Alek Du
2009-06-17 9:36 ` Ben Nizette
2009-06-16 1:21 ` [PATCH] gpiolib: Add gpio_detect, " Alek Du
2009-06-16 8:45 ` Ben Dooks
2009-06-16 8:51 ` Alek Du
2009-06-16 9:02 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090616092848.7bb60f21@dxy.sh.intel.com \
--to=alek.du@intel.com \
--cc=ben-linux@fluff.org \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox