Re: [PATCH] cleanup find_task_by_pid variants

[Andrew Morton <akpm@linux-foundation.org>]

On Tue, 16 Jun 2009 21:18:32 +0200
Christoph Hellwig <hch@lst.de> wrote:

> 
> On Thu, May 14, 2009 at 06:57:50PM +0200, Christoph Hellwig wrote:
> > 
> > find_task_by_pid_type_ns is only used to implement find_task_by_vpid and
> > find_task_by_pid_ns, but both of them pass PIDTYPE_PID as first argument.
> > So just fold find_task_by_pid_type_ns into find_task_by_pid_ns and use
> > find_task_by_pid_ns to implement find_task_by_vpid.
> > 
> > While we're at it also remove the exports for find_task_by_pid_ns and
> > find_task_by_vpid - we don't have any modular callers left as the only
> > modular caller of he old pre pid namespace find_task_by_pid (gfs2)
> > was switched to pid_task which operates on a struct pid pointer instead
> > of a pid_t.  Given the confusion about pid_t values vs namespace that's
> > generally the better option anyway and I think we're better of restricting
> > modules to do it that way.
> > 
>
> Is anyone going to pick this up?

I already did: http://userweb.kernel.org/~akpm/mmotm/broken-out/pids-clean-up-find_task_by_pid-variants.patch