From: Vivek Goyal <vgoyal@redhat.com>
To: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, dm-devel@redhat.com,
jens.axboe@oracle.com, nauman@google.com, dpshah@google.com,
lizf@cn.fujitsu.com, mikew@google.com, fchecconi@gmail.com,
paolo.valente@unimore.it, ryov@valinux.co.jp,
fernando@oss.ntt.co.jp, s-uchida@ap.jp.nec.com,
taka@valinux.co.jp, jmoyer@redhat.com, dhaval@linux.vnet.ibm.com,
balbir@linux.vnet.ibm.com, righi.andrea@gmail.com,
m-ikeda@ds.jp.nec.com, jbaron@redhat.com, agk@redhat.com,
snitzer@redhat.com, akpm@linux-foundation.org,
peterz@infradead.org
Subject: Re: [PATCH 02/19] io-controller: Common flat fair queuing code in elevaotor layer
Date: Tue, 16 Jun 2009 09:02:27 -0400 [thread overview]
Message-ID: <20090616130227.GA10730@redhat.com> (raw)
In-Reply-To: <4A37175C.80906@cn.fujitsu.com>
On Tue, Jun 16, 2009 at 11:54:04AM +0800, Gui Jianfeng wrote:
> Vivek Goyal wrote:
> ...
> > +
> > +int elv_nr_busy_rt_ioq(struct elevator_queue *e)
> > +{
> > + return e->efqd.busy_rt_queues;
> > +}
> > +EXPORT_SYMBOL(elv_nr_busy_rt_ioq);
>
> This function is no need now.
>
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Thanks Gui. Queued for next posting.
Thanks
Vivek
> ---
> block/elevator-fq.c | 6 ------
> block/elevator-fq.h | 1 -
> 2 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/block/elevator-fq.c b/block/elevator-fq.c
> index f33155c..912ac6a 100644
> --- a/block/elevator-fq.c
> +++ b/block/elevator-fq.c
> @@ -2553,12 +2553,6 @@ int elv_nr_busy_ioq(struct elevator_queue *e)
> }
> EXPORT_SYMBOL(elv_nr_busy_ioq);
>
> -int elv_nr_busy_rt_ioq(struct elevator_queue *e)
> -{
> - return e->efqd.busy_rt_queues;
> -}
> -EXPORT_SYMBOL(elv_nr_busy_rt_ioq);
> -
> int elv_hw_tag(struct elevator_queue *e)
> {
> return e->efqd.hw_tag;
> diff --git a/block/elevator-fq.h b/block/elevator-fq.h
> index 0939735..285a1ff 100644
> --- a/block/elevator-fq.h
> +++ b/block/elevator-fq.h
> @@ -711,7 +711,6 @@ extern void io_group_set_async_queue(struct io_group *iog, int ioprio_class,
> extern struct io_group *io_get_io_group(struct request_queue *q,
> struct bio *bio, int create);
> extern int elv_nr_busy_ioq(struct elevator_queue *e);
> -extern int elv_nr_busy_rt_ioq(struct elevator_queue *e);
> extern struct io_queue *elv_alloc_ioq(struct request_queue *q, gfp_t gfp_mask);
> extern void elv_free_ioq(struct io_queue *ioq);
>
> --
> 1.5.4.rc3
>
next prev parent reply other threads:[~2009-06-16 13:05 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 2:08 [RFC] IO scheduler based IO controller V4 Vivek Goyal
2009-06-09 2:08 ` [PATCH 01/19] io-controller: Documentation Vivek Goyal
2009-06-09 2:08 ` [PATCH 02/19] io-controller: Common flat fair queuing code in elevaotor layer Vivek Goyal
2009-06-09 8:45 ` Gui Jianfeng
2009-06-16 3:54 ` Gui Jianfeng
2009-06-16 13:02 ` Vivek Goyal [this message]
2009-06-16 19:44 ` Divyesh Shah
2009-06-17 12:59 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 03/19] io-controller: Charge for time slice based on average disk rate Vivek Goyal
2009-06-09 2:08 ` [PATCH 04/19] io-controller: Modify cfq to make use of flat elevator fair queuing Vivek Goyal
2009-06-11 6:12 ` Gui Jianfeng
2009-06-11 14:21 ` Vivek Goyal
2009-06-15 8:56 ` Gui Jianfeng
2009-06-15 13:02 ` Vivek Goyal
2009-06-17 2:22 ` Gui Jianfeng
2009-06-17 13:00 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 05/19] io-controller: Common hierarchical fair queuing code in elevaotor layer Vivek Goyal
2009-06-09 2:08 ` [PATCH 06/19] io-controller: cfq changes to use " Vivek Goyal
2009-06-09 2:08 ` [PATCH 07/19] io-controller: Export disk time used and nr sectors dipatched through cgroups Vivek Goyal
2009-06-09 2:08 ` [PATCH 08/19] io-controller: idle for sometime on sync queue before expiring it Vivek Goyal
2009-06-09 2:08 ` [PATCH 09/19] io-controller: Separate out queue and data Vivek Goyal
2009-06-09 2:08 ` [PATCH 10/19] io-conroller: Prepare elevator layer for single queue schedulers Vivek Goyal
2009-06-11 8:10 ` Gui Jianfeng
2009-06-11 14:41 ` Vivek Goyal
2009-06-12 0:37 ` Gui Jianfeng
2009-06-15 13:00 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 11/19] io-controller: noop changes for hierarchical fair queuing Vivek Goyal
2009-06-09 2:08 ` [PATCH 12/19] io-controller: deadline " Vivek Goyal
2009-06-09 2:08 ` [PATCH 13/19] io-controller: anticipatory " Vivek Goyal
2009-06-09 2:08 ` [PATCH 14/19] blkio_cgroup patches from Ryo to track async bios Vivek Goyal
2009-06-09 2:08 ` [PATCH 15/19] io-controller: map async requests to appropriate cgroup Vivek Goyal
2009-06-17 9:17 ` Gui Jianfeng
2009-06-17 13:00 ` Vivek Goyal
2009-06-09 2:08 ` [PATCH 16/19] io-controller: Per cgroup request descriptor support Vivek Goyal
2009-06-09 2:09 ` [PATCH 17/19] io-controller: Support per cgroup per device weights and io class Vivek Goyal
2009-06-10 7:44 ` Gui Jianfeng
2009-06-10 13:22 ` Vivek Goyal
2009-06-09 2:09 ` [PATCH 18/19] io-controller: Debug hierarchical IO scheduling Vivek Goyal
2009-06-19 1:40 ` Gui Jianfeng
2009-06-19 14:05 ` Vivek Goyal
2009-06-19 6:26 ` Gui Jianfeng
2009-06-19 14:08 ` Vivek Goyal
2009-06-09 2:09 ` [PATCH 19/19] io-controller: experimental debug patch for async queue wait before expiry Vivek Goyal
2009-06-09 4:22 ` [RFC] IO scheduler based IO controller V4 Gui Jianfeng
2009-06-09 13:52 ` Vivek Goyal
2009-06-10 1:05 ` Gui Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090616130227.GA10730@redhat.com \
--to=vgoyal@redhat.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=dm-devel@redhat.com \
--cc=dpshah@google.com \
--cc=fchecconi@gmail.com \
--cc=fernando@oss.ntt.co.jp \
--cc=guijianfeng@cn.fujitsu.com \
--cc=jbaron@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=m-ikeda@ds.jp.nec.com \
--cc=mikew@google.com \
--cc=nauman@google.com \
--cc=paolo.valente@unimore.it \
--cc=peterz@infradead.org \
--cc=righi.andrea@gmail.com \
--cc=ryov@valinux.co.jp \
--cc=s-uchida@ap.jp.nec.com \
--cc=snitzer@redhat.com \
--cc=taka@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox