[PATCH 0/2] eeepc-laptop: add 3G rfkill support for 901Go

[PATCH 0/2] eeepc-laptop: add 3G rfkill support for 901Go

[Janne Grunau]

Hi,

The asus_acpi module coming with the Eee PC 901 Go can turn the internal
3G modem on and off. I haven't found updated sources for it (only the
release from november 2007) but I haven't searched thoroughly nor
requested updated sources from Asus.
Adding support to eeepc-laptop looking at objdump output was easy enough
and probably faster than reply from Asus.

There remain only two little issues:
- the new values are not added to the end of the CM_ASL* enum but before
  CM_ASL_LID. I don't think it's a problem since it seems to be unused.
- The eeepc 1000HE reports 3G control support according to
  http://wiki.debian.org/DebianEeePC/Models but has no 3G modem. I assume
  this is an error in the bios.

Janne Grunau (2):
  eeepc-laptop: add 3G and Wimax CM_ASL values and acpi method names
  eeepc-laptop: add rfkill support for the 3G modem in Eee PC 901 Go

 drivers/platform/x86/eeepc-laptop.c |   62 +++++++++++++++++++++++++++++++++-
 1 files changed, 60 insertions(+), 2 deletions(-)

Re: [PATCH 0/2] eeepc-laptop: add 3G rfkill support for 901Go

[Corentin Chary]

On Sat, Jun 13, 2009 at 12:32 AM, Janne Grunau<j@jannau.net> wrote:
> Hi,
>
> The asus_acpi module coming with the Eee PC 901 Go can turn the internal
> 3G modem on and off. I haven't found updated sources for it (only the
> release from november 2007) but I haven't searched thoroughly nor
> requested updated sources from Asus.
> Adding support to eeepc-laptop looking at objdump output was easy enough
> and probably faster than reply from Asus.
>
> There remain only two little issues:
> - the new values are not added to the end of the CM_ASL* enum but before
>  CM_ASL_LID. I don't think it's a problem since it seems to be unused.
> - The eeepc 1000HE reports 3G control support according to
>  http://wiki.debian.org/DebianEeePC/Models but has no 3G modem. I assume
>  this is an error in the bios.

Hi,
First,
Could you fill http://dev.iksaif.net/projects/acpi4asus/wiki/CMSG with
your model CMSG ?

Then, I was working on a patch to refactor rfkill code in
eeepc-laptop. With this patch, adding 3g rfkill
is only 15-20 lines. I'll add it to acpi4asus git tree soon.
>From here:
 - I can rework your patch
- you can re-send it when rfkill refactoring is here.

as you want =).

-- 
Corentin Chary
http://xf.iksaif.net - http://uffs.org

Re: [PATCH 0/2] eeepc-laptop: add 3G rfkill support for 901Go

[Janne Grunau]

On Sat, Jun 13, 2009 at 08:52:17AM +0200, Corentin Chary wrote:
> First,
> Could you fill http://dev.iksaif.net/projects/acpi4asus/wiki/CMSG with
> your model CMSG ?

done, I suspect there's an error for the 701 and 901 in that table.
CM_ASL_CARDREADER should be 1 instead of CM_ASL_MODEM.
http://wiki.debian.org/DebianEeePC/Models supports that.

Do you plan to update eeepc-laptop with all CM_ASL bits?

> Then, I was working on a patch to refactor rfkill code in
> eeepc-laptop. With this patch, adding 3g rfkill
> is only 15-20 lines.

good, I was too lazy to refactor it.

> I'll add it to acpi4asus git tree soon.
> From here:
>  - I can rework your patch
> - you can re-send it when rfkill refactoring is here.
> 
> as you want =).

Drop me a mail when you're done but doesn't really matter who does it.

Janne

Re: [PATCH 0/2] eeepc-laptop: add 3G rfkill support for 901Go

[Corentin Chary]

On Sat, Jun 13, 2009 at 1:06 PM, Janne Grunau<j@jannau.net> wrote:
> On Sat, Jun 13, 2009 at 08:52:17AM +0200, Corentin Chary wrote:
>> First,
>> Could you fill http://dev.iksaif.net/projects/acpi4asus/wiki/CMSG with
>> your model CMSG ?
>
> done, I suspect there's an error for the 701 and 901 in that table.
> CM_ASL_CARDREADER should be 1 instead of CM_ASL_MODEM.
> http://wiki.debian.org/DebianEeePC/Models supports that.

I'll check that, thanks

> Do you plan to update eeepc-laptop with all CM_ASL bits?

All CM_ASL bits found in latest asus_acpi driver, yep.

>> Then, I was working on a patch to refactor rfkill code in
>> eeepc-laptop. With this patch, adding 3g rfkill
>> is only 15-20 lines.
>
> good, I was too lazy to refactor it.
>
>> I'll add it to acpi4asus git tree soon.
>> From here:
>>  - I can rework your patch
>> - you can re-send it when rfkill refactoring is here.
>>
>> as you want =).
>
> Drop me a mail when you're done but doesn't really matter who does it.

Ok


-- 
Corentin Chary
http://xf.iksaif.net - http://uffs.org

Re: [PATCH 0/2] eeepc-laptop: add 3G rfkill support for 901Go

[Corentin Chary]

On Sat, Jun 13, 2009 at 1:36 PM, Corentin Chary<corentin.chary@gmail.com> wrote:
> On Sat, Jun 13, 2009 at 1:06 PM, Janne Grunau<j@jannau.net> wrote:
>> On Sat, Jun 13, 2009 at 08:52:17AM +0200, Corentin Chary wrote:
>>> First,
>>> Could you fill http://dev.iksaif.net/projects/acpi4asus/wiki/CMSG with
>>> your model CMSG ?
>>
>> done, I suspect there's an error for the 701 and 901 in that table.
>> CM_ASL_CARDREADER should be 1 instead of CM_ASL_MODEM.
>> http://wiki.debian.org/DebianEeePC/Models supports that.
>
> I'll check that, thanks
>
>> Do you plan to update eeepc-laptop with all CM_ASL bits?
>
> All CM_ASL bits found in latest asus_acpi driver, yep.
>
>>> Then, I was working on a patch to refactor rfkill code in
>>> eeepc-laptop. With this patch, adding 3g rfkill
>>> is only 15-20 lines.
>>
>> good, I was too lazy to refactor it.
>>
>>> I'll add it to acpi4asus git tree soon.
>>> From here:
>>>  - I can rework your patch
>>> - you can re-send it when rfkill refactoring is here.
>>>
>>> as you want =).
>>
>> Drop me a mail when you're done but doesn't really matter who does it.

You can find the patch here,
http://git.iksaif.net/?p=acpi4asus.git;a=shortlog;h=refs/heads/eeepc-laptop



-- 
Corentin Chary
http://xf.iksaif.net - http://uffs.org

Re: [PATCH 0/2] eeepc-laptop: add 3G rfkill support for 901Go

[Janne Grunau]

On Mon, Jun 15, 2009 at 01:48:03PM +0200, Corentin Chary wrote:
> 
> You can find the patch here,
> http://git.iksaif.net/?p=acpi4asus.git;a=shortlog;h=refs/heads/eeepc-laptop

Thanks, rfkill for the 3g modem works as expected. But the wlan hotkey
Fn + F1 doesn't work. I haven't had time to look at it.

Janne