From: Jens Axboe <jens.axboe@oracle.com>
To: Steve Rottinger <steve@pentek.com>
Cc: Leon Woestenberg <leon.woestenberg@gmail.com>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [RFC][PATCH] add support for shrinking/growing a pipe (Was "Re: splice methods in character device driver")
Date: Tue, 16 Jun 2009 20:24:59 +0200 [thread overview]
Message-ID: <20090616182459.GC11363@kernel.dk> (raw)
In-Reply-To: <4A37B4D8.5090404@pentek.com>
On Tue, Jun 16 2009, Steve Rottinger wrote:
> >> Although, I think that most of the overhead that I was experiencing
> >> came from the cumulative
> >> overhead of each splice system call. I increased my pipe size using
> >> Jens' pipe size patch,
> >> from 16 to 256 pages, and this had a huge effect -- the speed of my
> >> transfers more than doubled.
> >> Pipe sizes larger that 256 pages, cause my kernel to crash.
> >>
> >
> > Yes, the system call is more expensive. Increasing the pipe size can
> > definitely help there.
> >
> >
> I know that you have been asked this before, but is there any chance
> that we can
> get the pipe size patch into the kernel mainline? It seems like it is
> essential to
> moving data fast using the splice interface.
Sure, the only unresolved issue with it is what sort of interface to
export for changing the pipe size. I went with fcntl().
Linus, I think we discussed this years ago. The patch in question is
here:
http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=24547ac4d97bebb58caf9ce58bd507a95c812a3f
I'd like to get it in now, there has been several requests for this in
the past. But I didn't want to push it before this was resolved.
I don't know whether other operating systems allow this functionality,
and if they do what interface they use. I suspect that our need is
somewhat special, since we have splice.
--
Jens Axboe
next prev parent reply other threads:[~2009-06-16 18:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 14:40 splice methods in character device driver Steve Rottinger
2009-05-11 19:22 ` Jens Axboe
2009-05-13 16:59 ` Steve Rottinger
2009-06-03 21:32 ` Leon Woestenberg
2009-06-04 7:32 ` Jens Axboe
2009-06-04 13:20 ` Steve Rottinger
2009-06-12 19:21 ` Leon Woestenberg
2009-06-12 19:59 ` Jens Axboe
2009-06-12 20:45 ` Steve Rottinger
2009-06-16 11:59 ` Jens Axboe
2009-06-16 15:06 ` Steve Rottinger
2009-06-16 18:24 ` Jens Axboe [this message]
2009-06-16 18:28 ` Jens Axboe
2009-06-06 21:25 ` Leon Woestenberg
2009-06-08 7:05 ` Jens Axboe
2009-06-12 22:05 ` Leon Woestenberg
2009-06-13 7:26 ` Jens Axboe
2009-06-13 20:04 ` Leon Woestenberg
2009-06-16 11:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090616182459.GC11363@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=leon.woestenberg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steve@pentek.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox