From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Char: tty, fix tty_port_block_til_ready waiting
Date: Tue, 16 Jun 2009 23:31:52 -0700 [thread overview]
Message-ID: <20090616233152.41e43277.akpm@linux-foundation.org> (raw)
In-Reply-To: <1245179580-25402-1-git-send-email-jirislaby@gmail.com>
On Tue, 16 Jun 2009 21:13:00 +0200 Jiri Slaby <jirislaby@gmail.com> wrote:
> Use DEFINE_WAIT instead of DECLARE_WAITQUEUE, because we use
> prepare/finish_wait since commit
> 3e3b5c087799e536871c8261b05bc28e4783c8da
> (tty: use prepare/finish_wait)
>
> Otherwise we would oops in finish_wait.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> ---
> drivers/char/tty_port.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/tty_port.c b/drivers/char/tty_port.c
> index 62dadfc..a8ed648 100644
> --- a/drivers/char/tty_port.c
> +++ b/drivers/char/tty_port.c
> @@ -193,7 +193,7 @@ int tty_port_block_til_ready(struct tty_port *port,
> {
> int do_clocal = 0, retval;
> unsigned long flags;
> - DECLARE_WAITQUEUE(wait, current);
> + DEFINE_WAIT(wait, current);
That won't compile. DEFINE_WAIT(wait) will though.
next prev parent reply other threads:[~2009-06-17 6:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 19:13 [PATCH 1/1] Char: tty, fix tty_port_block_til_ready waiting Jiri Slaby
2009-06-17 6:31 ` Andrew Morton [this message]
2009-06-17 7:02 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090616233152.41e43277.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox