public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-s390@vger.kernel.org, heiko.carstens@de.ibm.com
Subject: Re: [PATCH] s390: remove DEBUG_MALLOC
Date: Wed, 17 Jun 2009 09:23:50 +0200	[thread overview]
Message-ID: <20090617092350.7a391ad5@skybase> (raw)
In-Reply-To: <Pine.LNX.4.64.0906170941340.29445@melkki.cs.Helsinki.FI>

On Wed, 17 Jun 2009 09:42:38 +0300 (EEST)
Pekka J Enberg <penberg@cs.helsinki.fi> wrote:

> The kernel now has kmemleak and kmemtrace so there's no reason to keep
> this ugly s390 hack around. I am not sure how it's supposed to work on
> SMP anyway as it uses a global variable to temporarily store the return 
> value of all kmalloc() calls:
> 
>   void *b;
> 
>   #define kmalloc(x...) (PRINT_INFO(" kmalloc %p\n",b=kmalloc(x)),b)

Ouch! Yes, we better remove this quickly before anybody else sees it.
I'll add it to git390.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.


      reply	other threads:[~2009-06-17  7:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-17  6:42 [PATCH] s390: remove DEBUG_MALLOC Pekka J Enberg
2009-06-17  7:23 ` Martin Schwidefsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090617092350.7a391ad5@skybase \
    --to=schwidefsky@de.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox