From: Andrew Morton <akpm@linux-foundation.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [GIT PULL] block updates for 2.6.31-rc1
Date: Wed, 17 Jun 2009 15:17:54 -0700 [thread overview]
Message-ID: <20090617151754.e7c4c58c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090616071823.GL11363@kernel.dk>
On Tue, 16 Jun 2009 09:18:23 +0200
Jens Axboe <jens.axboe@oracle.com> wrote:
> Martin K. Petersen (1):
> block: Introduce helper to reset queue limits to default values
i386 allnoconfig:
block/blk-settings.c: In function 'blk_set_default_limits':
block/blk-settings.c:115: warning: large integer implicitly truncated to unsigned type
The patch was sent on June 12, acked on June 15, merged into mainline
June 16 and never made an appearance in linux-next.
It doesn't look like it'll cause any runtime problems, but that just
means we got lucky.
Suggested fix is to use plain old "-1", rather than (incorrectly)
guessing what type the caller might be assigning to.
--- a/include/linux/blkdev.h~a
+++ a/include/linux/blkdev.h
@@ -702,7 +702,7 @@ extern unsigned long blk_max_low_pfn, bl
#else
#define BLK_BOUNCE_HIGH -1ULL
#endif
-#define BLK_BOUNCE_ANY (-1ULL)
+#define BLK_BOUNCE_ANY (-1)
#define BLK_BOUNCE_ISA (ISA_DMA_THRESHOLD)
/*
_
Or is the code just buggy? What are the units of BLK_BOUNCE_HIGH,
BLK_BOUNCE_ANY and BLK_BOUNCE_ISA? Seems that they are physical
addresses. So why are we copying one of these onto a variable which
records pfns?
If BLK_BOUNCE_ANY's units are indeed pfns (not the case afaict) then
using a ULL was inappropriate.
next prev parent reply other threads:[~2009-06-17 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 7:18 [GIT PULL] block updates for 2.6.31-rc1 Jens Axboe
2009-06-17 22:17 ` Andrew Morton [this message]
2009-06-17 22:49 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090617151754.e7c4c58c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox