From: Ingo Molnar <mingo@elte.hu>
To: Subrata Modak <subrata@linux.vnet.ibm.com>
Cc: "Figo.zhang" <figo1802@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
Sumit Panchasara <sumit.panchasara@einfochips.com>,
"'Sachin P Sant'" <sachinp@linux.vnet.ibm.com>,
"'H. Peter Anvin'" <hpa@zytor.com>,
"'Frans Pop'" <elendil@planet.nl>,
"'Andi Kleen'" <andi@firstfloor.org>,
"'Thomas Gleixner'" <tglx@linutronix.de>,
"'Balbir Singh'" <balbir@linux.vnet.ibm.com>,
Jaswinder Singh Rajput <jaswinder@kernel.org>
Subject: Re: [PATCH]x86-tsc.c : fix compile warning
Date: Wed, 17 Jun 2009 17:28:02 +0200 [thread overview]
Message-ID: <20090617152802.GB6042@elte.hu> (raw)
In-Reply-To: <1245248241.4870.12.camel@subratamodak.linux.ibm.com>
* Subrata Modak <subrata@linux.vnet.ibm.com> wrote:
> > fix compile warning:
> > arch/x86/kernel/tsc.c: In function ‘time_cpufreq_notifier’:
> > arch/x86/kernel/tsc.c:635: warning: ‘dummy’ may be used uninitialized in
> > this function
> >
> > Signed-off-by: Figo.zhang <figo1802@gmail.com>
>
> Hello Figo,
>
> Please refer to the following links on discussion on this issue earlier:
> http://lkml.org/lkml/2009/5/19/312
> http://lkml.org/lkml/2009/5/19/301
> http://lkml.org/lkml/2009/5/20/23
>
> I tried to fix it in some other way.
Ah, and you fixed in what a superior way: you improved the code in
the process :-) This is how warnings should be fixed really.
Applied.
We apparently missed it when you sent it in May - generally feel
free to re-send patches if you dont see a commit notification within
a few days.
Thanks,
Ingo
next prev parent reply other threads:[~2009-06-17 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 13:57 [PATCH]x86-tsc.c : fix compile warning Figo.zhang
[not found] ` <bb33bcf20906170700i4a4ea802yf1da08e9870d6221@mail.gmail.com>
2009-06-17 14:17 ` Subrata Modak
2009-06-17 14:20 ` Figo.zhang
2009-06-17 15:28 ` Ingo Molnar [this message]
2009-06-17 16:11 ` Subrata Modak
2009-06-17 16:12 ` Frans Pop
2009-06-17 16:23 ` Ingo Molnar
2009-06-17 16:55 ` Subrata Modak
2009-06-18 7:27 ` Balbir Singh
2009-06-18 8:48 ` Subrata Modak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090617152802.GB6042@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=elendil@planet.nl \
--cc=figo1802@gmail.com \
--cc=hpa@zytor.com \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachinp@linux.vnet.ibm.com \
--cc=subrata@linux.vnet.ibm.com \
--cc=sumit.panchasara@einfochips.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox