From: David Brownell <david-b@pacbell.net>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
haavard.skinnemoen@atmel.com, patrice.vilchez@atmel.com
Subject: Re: [PATCH 1/2 v2] at91/USB: Add USB drivers for at91sam9g45 series
Date: Fri, 19 Jun 2009 00:45:16 -0700 [thread overview]
Message-ID: <200906190045.16496.david-b@pacbell.net> (raw)
In-Reply-To: <1244720355-10740-1-git-send-email-nicolas.ferre@atmel.com>
On Thursday 11 June 2009, Nicolas Ferre wrote:
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -124,7 +124,7 @@ choice
>
> config USB_GADGET_AT91
> boolean "Atmel AT91 USB Device Port"
> - depends on ARCH_AT91 && !ARCH_AT91SAM9RL && !ARCH_AT91CAP9
> + depends on ARCH_AT91 && !ARCH_AT91SAM9RL && !ARCH_AT91CAP9 && !ARCH_AT91SAM9G45
> select USB_GADGET_SELECTED
> help
> Many Atmel AT91 processors (such as the AT91RM2000) have a
> @@ -143,7 +143,7 @@ config USB_AT91
> config USB_GADGET_ATMEL_USBA
> boolean "Atmel USBA"
> select USB_GADGET_DUALSPEED
> - depends on AVR32 || ARCH_AT91CAP9 || ARCH_AT91SAM9RL
> + depends on AVR32 || ARCH_AT91CAP9 || ARCH_AT91SAM9RL || ARCH_AT91SAM9G45
> help
> USBA is the integrated high-speed USB Device controller on
> the AT32AP700x, some AT91SAM9 and AT91CAP9 processors from Atmel.
I understand the temptation, but please keep the gadget-side and host-side
support in separate patches.
If/when high speed OTG is supported on AT91 systems, that support would need
to touch both sides of the USB stack. Otherwise, avoid doing that.
next prev parent reply other threads:[~2009-06-19 7:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 11:39 [PATCH 1/2 v2] at91/USB: Add USB drivers for at91sam9g45 series Nicolas Ferre
2009-06-19 7:45 ` David Brownell [this message]
[not found] ` <6af1745bf0de30efbd68addd05c2670311c7743a.1245775871.git.nicolas.ferre@atmel.com>
2009-06-23 16:58 ` [PATCH 1/3 v3] at91/USB: Add USB gadget driver selection " Nicolas Ferre
2009-06-26 5:22 ` David Brownell
2009-06-26 12:38 ` Nicolas Ferre
[not found] ` <3a789bc6cfd230935479336d21c497476488340f.1245775871.git.nicolas.ferre@atmel.com>
2009-06-23 16:58 ` [PATCH 2/3 v3] at91/USB: modify OHCI driver to allow shared interrupts Nicolas Ferre
2009-06-26 5:22 ` David Brownell
[not found] ` <ef5db5944ede0d28d87f908232c77c34f87b0578.1245775871.git.nicolas.ferre@atmel.com>
2009-06-23 16:58 ` [PATCH 3/3 v3] at91/USB: Add USB EHCI driver for at91sam9g45 series Nicolas Ferre
2009-06-26 5:25 ` David Brownell
2009-06-26 10:53 ` [PATCH] " Nicolas Ferre
2009-06-23 21:29 ` [PATCH 1/3 v3] at91/USB: Add USB gadget driver selection " Jean-Christophe PLAGNIOL-VILLARD
2009-06-24 7:23 ` Nicolas Ferre
2009-06-19 7:54 ` [PATCH 1/2 v2] at91/USB: Add USB drivers " David Brownell
2009-06-19 7:59 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906190045.16496.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=patrice.vilchez@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox