Re: [PATCH 1/2 v2] at91/USB: Add USB drivers for at91sam9g45 series

David Brownell
2009-06-19T07:50:47Z

On Thursday 11 June 2009, Nicolas Ferre wrote:
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -124,7 +124,7 @@ choice
>
>  config USB_GADGET_AT91
>         boolean "Atmel AT91 USB Device Port"
> -       depends on ARCH_AT91 && !ARCH_AT91SAM9RL && !ARCH_AT91CAP9
> +       depends on ARCH_AT91 && !ARCH_AT91SAM9RL && !ARCH_AT91CAP9 && !ARCH_AT91SAM9G45
>         select USB_GADGET_SELECTED
>         help
>            Many Atmel AT91 processors (such as the AT91RM2000) have a
> @@ -143,7 +143,7 @@ config USB_AT91
>  config USB_GADGET_ATMEL_USBA
>         boolean "Atmel USBA"
>         select USB_GADGET_DUALSPEED
> -       depends on AVR32 || ARCH_AT91CAP9 || ARCH_AT91SAM9RL
> +       depends on AVR32 || ARCH_AT91CAP9 || ARCH_AT91SAM9RL || ARCH_AT91SAM9G45
>         help
>           USBA is the integrated high-speed USB Device controller on
>           the AT32AP700x, some AT91SAM9 and AT91CAP9 processors from Atmel.

I understand the temptation, but please keep the gadget-side and host-side
support in separate patches.

If/when high speed OTG is supported on AT91 systems, that support would need
to touch both sides of the USB stack. Otherwise, avoid doing that.