Re: [PATCH 1/2 v2] at91/USB: Add USB drivers for at91sam9g45 series

David Brownell
2009-06-19T07:54:26Z

On Thursday 11 June 2009, Nicolas Ferre wrote:
> --- a/drivers/usb/host/ohci-at91.c
> +++ b/drivers/usb/host/ohci-at91.c

Again, please split this out: OHCI patches separate from EHCI.

> @@ -148,7 +148,8 @@ static int usb_hcd_at91_probe(const struct hc_driver
> *driver, at91_start_hc(pdev);
>         ohci_hcd_init(hcd_to_ohci(hcd));
>
> -       retval = usb_add_hcd(hcd, pdev->resource[1].start, IRQF_DISABLED);
> +       retval = usb_add_hcd(hcd, pdev->resource[1].start,
> +                               IRQF_DISABLED | IRQF_SHARED);

Just pass IRQF_SHARED. That combination is not going be effective.