From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Roland McGrath <roland@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/17] arm: arch_ptrace clean-up
Date: Fri, 19 Jun 2009 10:13:23 +0100 [thread overview]
Message-ID: <20090619091323.GA18246@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20090425000732.ACB87FC3C8@magilla.sf.frob.com>
On Fri, Apr 24, 2009 at 05:07:32PM -0700, Roland McGrath wrote:
> This cleans up arch_ptrace() on arm to use the generic ptrace_request()
> for everything it can. This gets rid of the non-arch ptrace internals
> magic from the arch code.
It also changes the semantics a bit, and I don't buy the "it doesn't
matter" comments, especially in the PT_SINGLESTEP case. Having
PT_SINGLESTEP set the flag but later fail is not nice behaviour at all,
it means that, despite the ptrace call failing, the next time that the
task encounters a signal, it will enter single stepping mode.
Therefore, I believe this patch is wrong.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2009-06-19 9:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-25 0:06 [PATCH 0/17] tracehook & user_regset for ARM Roland McGrath
2009-04-25 0:07 ` [PATCH 01/17] arm: arch_ptrace clean-up Roland McGrath
2009-06-19 9:13 ` Russell King [this message]
2009-06-24 6:55 ` Roland McGrath
2009-04-25 0:08 ` [PATCH 02/17] arm: arch_ptrace indentation Roland McGrath
2009-04-25 0:08 ` [PATCH 03/17] arm: tracehook_report_syscall Roland McGrath
2009-04-25 0:09 ` [PATCH 04/17] arm: tracehook_signal_handler Roland McGrath
2009-04-25 0:09 ` [PATCH 05/17] arm: TIF_NOTIFY_RESUME Roland McGrath
2009-04-25 0:10 ` [PATCH 06/17] arm: user_regset: general regs Roland McGrath
2009-04-25 0:10 ` [PATCH 07/17] arm: user_regset: FPU regs Roland McGrath
2009-04-25 0:11 ` [PATCH 08/17] arm: CORE_DUMP_USE_REGSET Roland McGrath
2009-04-25 0:11 ` [PATCH 09/17] arm: user_regset: VFP regs Roland McGrath
2009-04-25 0:12 ` [PATCH 10/17] arm: user_regset: VFP in core dumps Roland McGrath
2009-04-25 0:12 ` [PATCH 11/17] arm: user_regset: iWMMXt regs Roland McGrath
2009-04-25 0:12 ` [PATCH 12/17] arm: user_regset: iWMMXt in core dumps Roland McGrath
2009-04-27 22:43 ` Paul Mundt
2009-04-28 2:53 ` Roland McGrath
2009-04-25 0:13 ` [PATCH 13/17] arm: user_regset: Crunch regs Roland McGrath
2009-04-25 0:13 ` [PATCH 14/17] arm: user_regset: Crunch in core dumps Roland McGrath
2009-04-25 0:14 ` [PATCH 15/17] arm: user_regset: thread pointer " Roland McGrath
2009-04-25 0:15 ` [PATCH 16/17] arm: asm/syscall.h (unfinished) Roland McGrath
2009-06-19 9:31 ` Russell King
2009-06-24 8:56 ` Roland McGrath
2009-04-25 0:15 ` [PATCH 17/17] arm: HAVE_ARCH_TRACEHOOK Roland McGrath
2009-06-06 14:42 ` [PATCH 0/17] tracehook & user_regset for ARM Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090619091323.GA18246@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox