* [PATCH 1/1] HWMON: max6650, fix lock imbalance
@ 2009-06-19 21:26 Jiri Slaby
2009-06-19 23:02 ` Hans J. Koch
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2009-06-19 21:26 UTC (permalink / raw)
To: hjk; +Cc: lm-sensors, akpm, linux-kernel, Jiri Slaby
Add omitted update_lock to one switch/case in set_div.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
drivers/hwmon/max6650.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hwmon/max6650.c b/drivers/hwmon/max6650.c
index 86142a8..58f66be 100644
--- a/drivers/hwmon/max6650.c
+++ b/drivers/hwmon/max6650.c
@@ -418,6 +418,7 @@ static ssize_t set_div(struct device *dev, struct device_attribute *devattr,
data->count = 3;
break;
default:
+ mutex_unlock(&data->update_lock);
dev_err(&client->dev,
"illegal value for fan divider (%d)\n", div);
return -EINVAL;
--
1.6.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] HWMON: max6650, fix lock imbalance
2009-06-19 21:26 [PATCH 1/1] HWMON: max6650, fix lock imbalance Jiri Slaby
@ 2009-06-19 23:02 ` Hans J. Koch
2009-06-20 8:21 ` [lm-sensors] " Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: Hans J. Koch @ 2009-06-19 23:02 UTC (permalink / raw)
To: Jiri Slaby; +Cc: hjk, lm-sensors, akpm, linux-kernel
On Fri, Jun 19, 2009 at 11:26:35PM +0200, Jiri Slaby wrote:
> Add omitted update_lock to one switch/case in set_div.
Ahem, yes, thanks!
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Hans J. Koch <hjk@linutronix.de>
> ---
> drivers/hwmon/max6650.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hwmon/max6650.c b/drivers/hwmon/max6650.c
> index 86142a8..58f66be 100644
> --- a/drivers/hwmon/max6650.c
> +++ b/drivers/hwmon/max6650.c
> @@ -418,6 +418,7 @@ static ssize_t set_div(struct device *dev, struct device_attribute *devattr,
> data->count = 3;
> break;
> default:
> + mutex_unlock(&data->update_lock);
> dev_err(&client->dev,
> "illegal value for fan divider (%d)\n", div);
> return -EINVAL;
> --
> 1.6.3.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH 1/1] HWMON: max6650, fix lock imbalance
2009-06-19 23:02 ` Hans J. Koch
@ 2009-06-20 8:21 ` Jean Delvare
0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2009-06-20 8:21 UTC (permalink / raw)
To: Hans J. Koch, Jiri Slaby; +Cc: akpm, linux-kernel, lm-sensors
On Sat, 20 Jun 2009 01:02:52 +0200, Hans J. Koch wrote:
> On Fri, Jun 19, 2009 at 11:26:35PM +0200, Jiri Slaby wrote:
> > Add omitted update_lock to one switch/case in set_div.
>
> Ahem, yes, thanks!
>
> >
> > Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>
> Signed-off-by: Hans J. Koch <hjk@linutronix.de>
>
> > ---
> > drivers/hwmon/max6650.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/hwmon/max6650.c b/drivers/hwmon/max6650.c
> > index 86142a8..58f66be 100644
> > --- a/drivers/hwmon/max6650.c
> > +++ b/drivers/hwmon/max6650.c
> > @@ -418,6 +418,7 @@ static ssize_t set_div(struct device *dev, struct device_attribute *devattr,
> > data->count = 3;
> > break;
> > default:
> > + mutex_unlock(&data->update_lock);
> > dev_err(&client->dev,
> > "illegal value for fan divider (%d)\n", div);
> > return -EINVAL;
Applied, thanks.
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-20 8:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-19 21:26 [PATCH 1/1] HWMON: max6650, fix lock imbalance Jiri Slaby
2009-06-19 23:02 ` Hans J. Koch
2009-06-20 8:21 ` [lm-sensors] " Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox