From: Arnd Bergmann <arnd@arndb.de>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Simek <monstr@monstr.eu>,
microblaze-uclinux@itee.uq.edu.au,
LKML <linux-kernel@vger.kernel.org>,
Remis Lima Baima <remis.developer@googlemail.com>
Subject: Re: [patch] ipc: unbreak 32-bit shmctl/semctl/msgctl
Date: Sat, 20 Jun 2009 08:20:56 +0000 [thread overview]
Message-ID: <200906200820.56707.arnd@arndb.de> (raw)
In-Reply-To: <20090620010939.GA3469@cmpxchg.org>
On Saturday 20 June 2009 01:09:39 am Johannes Weiner wrote:
> 31a985f "ipc: use __ARCH_WANT_IPC_PARSE_VERSION in ipc/util.h" would
> choose the implementation of ipc_parse_version() based on a symbol
> defined in <asm/unistd.h>.
>
> But it failed to also include this header and thus broke
> IPC_64-passing 32-bit userspace because the flag wasn't masked out
> properly anymore and the command not understood.
>
> Include <linux/unistd.h> to give the architecture a chance to ask for
> the no-no-op ipc_parse_version().
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Obviously fixes the bug I introduced, sorry for the trouble and thanks
for fixing it!
next prev parent reply other threads:[~2009-06-20 8:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 17:55 [PATCH 00/11] microblaze: use generic headers Arnd Bergmann
2009-06-18 17:55 ` [PATCH 01/11] ipc: use __ARCH_WANT_IPC_PARSE_VERSION in ipc/util.h Arnd Bergmann
2009-06-18 17:55 ` [PATCH 02/11] microblaze: remove init_mm Arnd Bergmann
2009-06-18 17:55 ` [PATCH 03/11] microblaze: fall back on generic header files for the ABI Arnd Bergmann
2009-07-01 11:34 ` [microblaze-uclinux] " Michal Simek
2009-07-01 11:42 ` Arnd Bergmann
2009-07-01 12:09 ` Michal Simek
2009-07-01 13:41 ` Arnd Bergmann
2009-07-01 22:52 ` John Williams
2009-07-02 9:36 ` Arnd Bergmann
2009-07-03 5:55 ` Michal Simek
2009-07-03 17:16 ` Arnd Bergmann
2009-06-18 17:55 ` [PATCH 04/11] microblaze: use generic unistd.h syscall list Arnd Bergmann
2009-06-18 17:55 ` [PATCH 05/11] microblaze: clean up signal handling Arnd Bergmann
2009-06-18 17:55 ` [PATCH 06/11] microblaze: use generic syscalls.h Arnd Bergmann
2009-06-18 17:55 ` [PATCH 07/11] microblaze: make syscall_table implementation generic Arnd Bergmann
2009-06-18 17:55 ` [PATCH 08/11] microblaze: use the generic lib/checksum.c Arnd Bergmann
2009-07-01 11:35 ` [microblaze-uclinux] " Michal Simek
2009-06-18 17:55 ` [PATCH 09/11] microblaze: convert all simple headers to use asm-generic Arnd Bergmann
2009-07-01 11:35 ` [microblaze-uclinux] " Michal Simek
2009-06-18 17:55 ` [PATCH 10/11] microblaze: use generic system.h Arnd Bergmann
2009-07-01 11:19 ` [microblaze-uclinux] " Michal Simek
2009-07-01 11:39 ` Arnd Bergmann
2009-07-01 11:51 ` Michal Simek
2009-06-18 17:55 ` [PATCH 11/11] microblaze: remove sys_ipc Arnd Bergmann
2009-06-18 22:31 ` [PATCH 01/11] ipc: use __ARCH_WANT_IPC_PARSE_VERSION in ipc/util.h Arnd Bergmann
2009-06-20 1:09 ` [patch] ipc: unbreak 32-bit shmctl/semctl/msgctl Johannes Weiner
2009-06-20 8:20 ` Arnd Bergmann [this message]
2009-06-21 19:01 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906200820.56707.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=remis.developer@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).