From: Jean Delvare <khali@linux-fr.org>
To: "Hans J. Koch" <hjk@linutronix.de>, Jiri Slaby <jirislaby@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH 1/1] HWMON: max6650, fix lock imbalance
Date: Sat, 20 Jun 2009 10:21:01 +0200 [thread overview]
Message-ID: <20090620102101.35e92c01@hyperion.delvare> (raw)
In-Reply-To: <20090619230252.GB3862@local>
On Sat, 20 Jun 2009 01:02:52 +0200, Hans J. Koch wrote:
> On Fri, Jun 19, 2009 at 11:26:35PM +0200, Jiri Slaby wrote:
> > Add omitted update_lock to one switch/case in set_div.
>
> Ahem, yes, thanks!
>
> >
> > Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>
> Signed-off-by: Hans J. Koch <hjk@linutronix.de>
>
> > ---
> > drivers/hwmon/max6650.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/hwmon/max6650.c b/drivers/hwmon/max6650.c
> > index 86142a8..58f66be 100644
> > --- a/drivers/hwmon/max6650.c
> > +++ b/drivers/hwmon/max6650.c
> > @@ -418,6 +418,7 @@ static ssize_t set_div(struct device *dev, struct device_attribute *devattr,
> > data->count = 3;
> > break;
> > default:
> > + mutex_unlock(&data->update_lock);
> > dev_err(&client->dev,
> > "illegal value for fan divider (%d)\n", div);
> > return -EINVAL;
Applied, thanks.
--
Jean Delvare
prev parent reply other threads:[~2009-06-20 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 21:26 [PATCH 1/1] HWMON: max6650, fix lock imbalance Jiri Slaby
2009-06-19 23:02 ` Hans J. Koch
2009-06-20 8:21 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090620102101.35e92c01@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=hjk@linutronix.de \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox