From: Dave Jones <davej@redhat.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [POWERNOW PATCH] x86: powernow-k8 move power management MSRs declaration to msr-index.h
Date: Sat, 20 Jun 2009 10:45:39 -0400 [thread overview]
Message-ID: <20090620144539.GA19293@redhat.com> (raw)
In-Reply-To: <1245493581.8613.4.camel@localhost.localdomain>
On Sat, Jun 20, 2009 at 03:56:21PM +0530, Jaswinder Singh Rajput wrote:
>
> Keep all MSRs declaration in msr-index.h to easily access MSRs declaration.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
The objection I have to this, is that there's no other use for these MSRs
outside of a powernow driver. They aren't "power management MSRs"
they're "powernow MSRs".
IMO msr-index should be used for MSRs that may be used by multiple files,
reducing duplication. Here we're just moving something around for
no obvious benefit.
Dave
prev parent reply other threads:[~2009-06-20 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-20 10:26 [POWERNOW PATCH] x86: powernow-k8 move power management MSRs declaration to msr-index.h Jaswinder Singh Rajput
2009-06-20 14:45 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090620144539.GA19293@redhat.com \
--to=davej@redhat.com \
--cc=hpa@zytor.com \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox