public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 1/2] function-graph: disable when both x86_32 and optimize for size are configured
Date: Sat, 20 Jun 2009 18:25:13 +0200	[thread overview]
Message-ID: <20090620162513.GD32377@elte.hu> (raw)
In-Reply-To: <20090618225248.476090968@goodmis.org>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 4a13e5a..1eac852 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -121,6 +121,7 @@ config FUNCTION_GRAPH_TRACER
>  	bool "Kernel Function Graph Tracer"
>  	depends on HAVE_FUNCTION_GRAPH_TRACER
>  	depends on FUNCTION_TRACER
> +	depends on !X86_32 || !CC_OPTIMIZE_FOR_SIZE
>  	default y

Hm, nice fix, but this is a quite nasty constraint - distros like to 
enable CC_OPTIMIZE_FOR_SIZE as it neatly trims the kernel's size by 
about 30%.

Just in case you have not checked yet: is there no way to turn off 
the specific gcc optimization that causes this? Or is it -Os itself 
that does this optimization?

	Ingo

  reply	other threads:[~2009-06-20 16:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-18 22:44 [PATCH 0/2] [GIT PULL][for 2.6.31] function graph gcc issue Steven Rostedt
2009-06-18 22:44 ` [PATCH 1/2] function-graph: disable when both x86_32 and optimize for size are configured Steven Rostedt
2009-06-20 16:25   ` Ingo Molnar [this message]
2009-06-20 22:24     ` Steven Rostedt
2009-06-21 10:45       ` Ingo Molnar
2009-06-18 22:44 ` [PATCH 2/2] function-graph: add stack frame test Steven Rostedt
2009-06-19  4:11   ` Frederic Weisbecker
2009-06-20 16:26 ` [PATCH 0/2] [GIT PULL][for 2.6.31] function graph gcc issue Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090620162513.GD32377@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox