public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	wey-yi.w.guy@intel.com
Subject: Re: iwlwifi: show qos AC parameters
Date: Sun, 21 Jun 2009 19:48:38 -0700	[thread overview]
Message-ID: <20090622024838.GB18153@kroah.com> (raw)
In-Reply-To: <20090621110727.74d95b28@infradead.org>

On Sun, Jun 21, 2009 at 11:07:27AM -0700, Arjan van de Ven wrote:
> On Mon, 15 Jun 2009 21:14:13 GMT
> Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
> 
> > +static ssize_t show_qos(struct device *d,
> > +				struct device_attribute *attr, char
> > *buf) +{
> > +	struct iwl_priv *priv = (struct iwl_priv *)d->driver_data;
> > +	char *p = buf;
> > +	int   q;
> > +
> > +	for (q = 0; q < AC_NUM; q++) {
> > +		p += sprintf(p, "\tcw_min\tcw_max\taifsn\ttxop\n");
> > +		p += sprintf(p, "AC[%d]\t%u\t%u\t%u\t%u\n", q,
> > +
> 
> wonder what happened to the "one value per file" sysfs rule...

Oh ick.

Thanks Arjan for the pointer.

Who's responsible for this file, and when is it going to be changed?

thanks,

greg k-h

  reply	other threads:[~2009-06-22  2:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200906152114.n5FLEDT3015406@hera.kernel.org>
2009-06-21 18:07 ` iwlwifi: show qos AC parameters Arjan van de Ven
2009-06-22  2:48   ` Greg KH [this message]
2009-06-22 14:06     ` Guy, Wey-Yi W
2009-06-22 16:23       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090622024838.GB18153@kroah.com \
    --to=greg@kroah.com \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wey-yi.w.guy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox