From: Matthew Wilcox <matthew@wil.cx>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Sam Ravnborg <sam@ravnborg.org>, Changli Gao <xiaosuo@gmail.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH update 2] SCSI: explain the hidden scsi_wait_scan Kconfig variable
Date: Mon, 22 Jun 2009 05:02:30 -0600 [thread overview]
Message-ID: <20090622110229.GR19977@parisc-linux.org> (raw)
In-Reply-To: <20090622095701.72c22150@lxorguk.ukuu.org.uk>
On Mon, Jun 22, 2009 at 09:57:01AM +0100, Alan Cox wrote:
> On Thu, 18 Jun 2009 21:03:23 +0200 (CEST)
> Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
>
> > People keep sending patches to expose CONFIG_SCSI_WAIT_SCAN as a tunable
> > item. These patches aren't accepted upstream, so let's stop the ongoing
> > irritation of people due to the unconditionally installed module and its
> > Kconfig symbol.
>
> How about the other possibility. People keepmaking it tunable because it
> makes sense for it to be tunable. Far better IMHO to make it tunable "if
> EMBEDDED"
It doesn't make sense for it to be tunable.
All it does is control whether or not scsi_wait_scan.ko is built.
Everyone who's complained about it has been of the form "I turned off
all modules, but this module gets built anyway". For them, the answer
is simple: Don't run "make modules_install".
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
prev parent reply other threads:[~2009-06-22 11:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 2:07 [PATCH] scsi_wait_scan: no option appears when configuring for scsi_wait_scan Changli Gao
2009-06-17 2:12 ` Matthew Wilcox
2009-06-17 10:07 ` [PATCH] SCSI: explain the hidden scsi_wait_scan Kconfig variable Stefan Richter
2009-06-17 10:28 ` Stefan Richter
2009-06-18 0:57 ` Changli Gao
2009-06-18 15:21 ` James Bottomley
2009-06-18 16:59 ` Sam Ravnborg
2009-06-18 19:03 ` [PATCH update 1] " Stefan Richter
2009-06-18 19:03 ` [PATCH update 2] " Stefan Richter
2009-06-22 8:57 ` Alan Cox
2009-06-22 11:02 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090622110229.GR19977@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox