public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2 -tip] perf_counter: parse-events.c introduce alias member in event_symbol
Date: Mon, 22 Jun 2009 13:32:56 +0200	[thread overview]
Message-ID: <20090622113256.GA22479@elte.hu> (raw)
In-Reply-To: <1245669268.17153.8.camel@localhost.localdomain>


* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

> 
> By introducing alias member in event_symbol :
> 
> 1. duplicate lines are removed, like:
>    cpu-cycles and cycles
>    branch-instructions and branches
>    context-switches and cs
>    cpu-migrations and migrations
> 
> 2. We can also add alias for another events.
> 
> Now ./perf list looks like :
> 
> List of pre-defined events (to be used in -e):
> 
>   cpu-cycles OR cycles                     [Hardware event]
>   instructions                             [Hardware event]
>   cache-references                         [Hardware event]
>   cache-misses                             [Hardware event]
>   branch-instructions OR branches          [Hardware event]
>   branch-misses                            [Hardware event]
>   bus-cycles                               [Hardware event]
> 
>   cpu-clock                                [Software event]
>   task-clock                               [Software event]
>   page-faults                              [Software event]
>   faults                                   [Software event]
>   minor-faults                             [Software event]
>   major-faults                             [Software event]
>   context-switches OR cs                   [Software event]
>   cpu-migrations OR migrations             [Software event]
> 
>   rNNN                                     [raw hardware event descriptor]
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
>  tools/perf/util/parse-events.c |   63 ++++++++++++++++++++++++----------------
>  1 files changed, 38 insertions(+), 25 deletions(-)

That looks useful - applied, thanks!

Another nice thing would be for 'perf list' to actually start each 
counter and stop it - and see whether it ticks. Perhaps that could 
be a new sub-command: 'perf test' ?

New 'perf' subcommands are added easily:

create a new tools/perf/builtin-foo.c file, add it to 
command-list.txt and to the Makefile - add it to perf.c's array of 
built-in commands and add a Documentation/perf-foo.txt file to 
generate manpages and usage strings for it.

	Ingo

  reply	other threads:[~2009-06-22 11:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-22 11:13 [PATCH 1/2 -tip] perf_counter: parse-events.c define separate declarations for H/W and S/W events Jaswinder Singh Rajput
2009-06-22 11:14 ` [PATCH 2/2 -tip] perf_counter: parse-events.c introduce alias member in event_symbol Jaswinder Singh Rajput
2009-06-22 11:32   ` Ingo Molnar [this message]
2009-06-22 13:00     ` Jaswinder Singh Rajput
2009-06-22 13:23       ` Jaswinder Singh Rajput
2009-06-22 14:10       ` Ingo Molnar
2009-06-22 19:55         ` Jaswinder Singh Rajput
2009-06-22 20:07           ` Jaswinder Singh Rajput
2009-06-23  8:27             ` Ingo Molnar
2009-06-23  8:24           ` Ingo Molnar
2009-06-23 14:02             ` Jaswinder Singh Rajput
2009-06-24  8:48               ` Ingo Molnar
2009-06-22 11:38   ` [tip:perfcounters/urgent] perf_counter tools: Introduce " tip-bot for Jaswinder Singh Rajput
2009-06-22 11:38 ` [tip:perfcounters/urgent] perf_counter tools: Define separate declarations for H/W and S/W events tip-bot for Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090622113256.GA22479@elte.hu \
    --to=mingo@elte.hu \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox