From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: David Miller <davem@davemloft.net>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] IDE: ide-taskfile.c fix compilation warning and cleanup
Date: Mon, 22 Jun 2009 12:50:36 +0200 [thread overview]
Message-ID: <200906221250.36318.bzolnier@gmail.com> (raw)
In-Reply-To: <1245650973.30547.3.camel@ht.satnam>
On Monday 22 June 2009 08:09:33 Jaswinder Singh Rajput wrote:
> @@ -248,8 +250,9 @@ void ide_pio_bytes(ide_drive_t *drive, struct ide_cmd *cmd,
> page = nth_page(page, (offset >> PAGE_SHIFT));
> offset %= PAGE_SIZE;
>
> - if (PageHighMem(page))
> - local_irq_save(flags);
> +#ifdef CONFIG_HIGHMEM
> + local_irq_save(flags);
> +#endif
>
> buf = kmap_atomic(page, KM_BIO_SRC_IRQ) + offset;
>
> @@ -269,8 +272,9 @@ void ide_pio_bytes(ide_drive_t *drive, struct ide_cmd *cmd,
>
> kunmap_atomic(buf, KM_BIO_SRC_IRQ);
>
> - if (PageHighMem(page))
> - local_irq_restore(flags);
> +#ifdef CONFIG_HIGHMEM
> + local_irq_restore(flags);
> +#endif
This part is incorrect (adds a performance regression for low-mem pages
w/ HIGHMEM=y) and seems to be accidental (nothing about it in the patch
description).
Besides I would suggest splitting the patch on fix and cleanup parts.
next prev parent reply other threads:[~2009-06-22 11:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 6:09 [PATCH] IDE: ide-taskfile.c fix compilation warning and cleanup Jaswinder Singh Rajput
2009-06-22 6:21 ` David Miller
2009-06-22 10:50 ` Bartlomiej Zolnierkiewicz [this message]
2009-06-26 3:18 ` Jaswinder Singh Rajput
2009-06-26 19:42 ` Bartlomiej Zolnierkiewicz
2009-06-27 9:18 ` Jaswinder Singh Rajput
2009-08-03 3:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906221250.36318.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox