Re: [PATCH 2/2] serial: bfin_5xx: fix building as module when early printk is enabled

[Andrew Morton <akpm@linux-foundation.org>]

On Fri, 12 Jun 2009 20:48:13 -0400
Mike Frysinger <vapier@gentoo.org> wrote:

> Since early printk only makes sense/works when the serial driver is built
> into the kernel, disable the option for this driver when it is going to be
> built as a module.  Otherwise we get build failures due to the ifdef
> handling.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  drivers/serial/bfin_5xx.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c
> index d7fcca1..b4a7650 100644
> --- a/drivers/serial/bfin_5xx.c
> +++ b/drivers/serial/bfin_5xx.c
> @@ -38,6 +38,10 @@
>  #include <asm/cacheflush.h>
>  #endif
>  
> +#ifdef CONFIG_SERIAL_BFIN_MODULE
> +# undef CONFIG_EARLY_PRINTK
> +#endif
> +
>  /* UART name and device definitions */
>  #define BFIN_SERIAL_NAME	"ttyBF"
>  #define BFIN_SERIAL_MAJOR	204

And that _does_ look like -stable material.

Alan, I queued both these as to-be-merged-by-you.  So if you want me to
stfu and merge them, please let me know.