Re: iwlwifi: show qos AC parameters

Re: iwlwifi: show qos AC parameters

[Arjan van de Ven]

On Mon, 15 Jun 2009 21:14:13 GMT
Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:

> +static ssize_t show_qos(struct device *d,
> +				struct device_attribute *attr, char
> *buf) +{
> +	struct iwl_priv *priv = (struct iwl_priv *)d->driver_data;
> +	char *p = buf;
> +	int   q;
> +
> +	for (q = 0; q < AC_NUM; q++) {
> +		p += sprintf(p, "\tcw_min\tcw_max\taifsn\ttxop\n");
> +		p += sprintf(p, "AC[%d]\t%u\t%u\t%u\t%u\n", q,
> +

wonder what happened to the "one value per file" sysfs rule...


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

Re: iwlwifi: show qos AC parameters

[Greg KH]

On Sun, Jun 21, 2009 at 11:07:27AM -0700, Arjan van de Ven wrote:
> On Mon, 15 Jun 2009 21:14:13 GMT
> Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
> 
> > +static ssize_t show_qos(struct device *d,
> > +				struct device_attribute *attr, char
> > *buf) +{
> > +	struct iwl_priv *priv = (struct iwl_priv *)d->driver_data;
> > +	char *p = buf;
> > +	int   q;
> > +
> > +	for (q = 0; q < AC_NUM; q++) {
> > +		p += sprintf(p, "\tcw_min\tcw_max\taifsn\ttxop\n");
> > +		p += sprintf(p, "AC[%d]\t%u\t%u\t%u\t%u\n", q,
> > +
> 
> wonder what happened to the "one value per file" sysfs rule...

Oh ick.

Thanks Arjan for the pointer.

Who's responsible for this file, and when is it going to be changed?

thanks,

greg k-h

RE: iwlwifi: show qos AC parameters

[Guy, Wey-Yi W]

Oh ok.
I will submit the patch to fix this.

Wey-Yi Guy
Intel Corporation
2111 N.E. 25th Avenue  M/S JF3-308                 
Hillsboro OR 97124-5961
USA
Work Phone: 503-264-6023 (OR)
Cell Phone: 503-329-8410
Email: wey-yi.w.guy@intel.com
 

-----Original Message-----
From: Greg KH [mailto:greg@kroah.com] 
Sent: Sunday, June 21, 2009 7:49 PM
To: Arjan van de Ven
Cc: Linux Kernel Mailing List; Guy, Wey-Yi W
Subject: Re: iwlwifi: show qos AC parameters

On Sun, Jun 21, 2009 at 11:07:27AM -0700, Arjan van de Ven wrote:
> On Mon, 15 Jun 2009 21:14:13 GMT
> Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
> 
> > +static ssize_t show_qos(struct device *d,
> > +				struct device_attribute *attr, char
> > *buf) +{
> > +	struct iwl_priv *priv = (struct iwl_priv *)d->driver_data;
> > +	char *p = buf;
> > +	int   q;
> > +
> > +	for (q = 0; q < AC_NUM; q++) {
> > +		p += sprintf(p, "\tcw_min\tcw_max\taifsn\ttxop\n");
> > +		p += sprintf(p, "AC[%d]\t%u\t%u\t%u\t%u\n", q,
> > +
> 
> wonder what happened to the "one value per file" sysfs rule...

Oh ick.

Thanks Arjan for the pointer.

Who's responsible for this file, and when is it going to be changed?

thanks,

greg k-h

Re: iwlwifi: show qos AC parameters

[Greg KH]

On Mon, Jun 22, 2009 at 07:06:14AM -0700, Guy, Wey-Yi W wrote:
> Oh ok.
> I will submit the patch to fix this.

Also, all new sysfs files need an entry in Documentation/ABI/.

thanks,

greg k-h