From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756490AbZFVO7p (ORCPT ); Mon, 22 Jun 2009 10:59:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751240AbZFVO7h (ORCPT ); Mon, 22 Jun 2009 10:59:37 -0400 Received: from mtagate5.de.ibm.com ([195.212.29.154]:53439 "EHLO mtagate5.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbZFVO7h (ORCPT ); Mon, 22 Jun 2009 10:59:37 -0400 Date: Mon, 22 Jun 2009 16:59:36 +0200 From: Martin Schwidefsky To: Ingo Molnar Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, Rob van der Heij , Heiko Carstens , john stultz , Andi Kleen , Peter Zijlstra Subject: Re: [patch 0/2] NOHZ vs. profile/oprofile v2 Message-ID: <20090622165936.0bb776e1@skybase> In-Reply-To: <20090622144110.GA9771@elte.hu> References: <20090603152223.083010123@de.ibm.com> <20090622162631.4b4dcee4@skybase> <20090622144110.GA9771@elte.hu> Organization: IBM Corporation X-Mailer: Claws Mail 3.7.1 (GTK+ 2.16.2; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Jun 2009 16:41:10 +0200 Ingo Molnar wrote: > Hm, this is rather ugly. Why not use hrtimers like 'perf' does when > it fallback-samples based on the timer tick? > > That method has three advantages: > > - no weird hookery needed > - resolution can go far beyond HZ > - it is evidently dynticks-safe Hmm, if we replace the HZ based oprofile tick with an hrtimer we should add an interface to configure the sample interval as well, no? Otherwise we just replace one timer event (HZ) with another (hrtimer). -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.