Re: [PATCH] PCI: remove pcibios_scan_all_fns()

[Matthew Wilcox <matthew@wil.cx>]

On Mon, Jun 22, 2009 at 11:20:24AM -0700, Jeremy Fitzhardinge wrote:
> > I'd like to know what the KVM / Xen / ... people think about this.
> > I don't know if they rely on function 5 being able to show up out of
> > the blue.
> 
> We want to be able to export specific functions to a particular domain,
> so it might see a PCI device with only function 5.
> 
> It looks like we lose that ability with this patch, is that right?

That would be correct.  I'm guessing your out-of-tree code sets
pcibios_scan_all_fns()?

Now, there are various options.  One is that you could remap config
space accesses -- domain:bus:dev.fn in the guest don't have to match
domain:bus:dev.fn in the host.  That's a certain amount of overhead in
every config space access, but it doesn't have to be a large one.

Another would be that you could create dummy devices in the guest at
function 0, and then the guest would scan all the functions.  A little
ugly, perhaps.

A third would be for guests to not do this scanning at all.  You could
present the devices through something like the openfirmware tree, and
create them insteaqd of scanning for them.  If you care about startup
time, this is probably the way to go.

There's probably other ways I haven't thought of ...

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."