Re: [PATCH] synclink_gt fix transmit race and timeout

Andrew Morton
2009-06-23T17:02:42Z

On Tue, 23 Jun 2009 11:55:06 -0600 Paul Fulghum <paulkf@microgate.com> wrote:

> Andrew Morton wrote:
> > I did have a couple of other comments on the patch which seem to have
> > been missed?
>
> Let's see, there was:
> "It fails to explain the user-visible effects of the bug which was fixed."

I'm referring to

Where did the "7" come from?

and

I have a suspicion that tx_stop() should use del_timer_sync(), not
del_timer(). What happens if the timer handler is concurrently
running?