[PATCH] block: adding __init/__exit macros to DAC960.c

[PATCH] block: adding __init/__exit macros to DAC960.c

[Peter Huewe]

From: Peter Huewe <peterhuewe@gmx.de>

Trivial patch which adds the __init and __exit macros to the module_init /
module_exit functions from drivers/block/DAC960.c
linux version 2.6.30

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
index f22ed6c..5b4a48b 100644
--- a/drivers/block/DAC960.c
+++ b/drivers/block/DAC960.c
@@ -7209,7 +7209,7 @@ static struct pci_driver DAC960_pci_driver = {
 	.remove		= DAC960_Remove,
 };
 
-static int DAC960_init_module(void)
+static int __init DAC960_init_module(void)
 {
 	int ret;
 
@@ -7221,7 +7221,7 @@ static int DAC960_init_module(void)
 	return ret;
 }
 
-static void DAC960_cleanup_module(void)
+static void __exit DAC960_cleanup_module(void)
 {
 	int i;

Re: [PATCH] block: adding __init/__exit macros to DAC960.c

[Peter Hüwe]

Am Freitag 12 Juni 2009 13:07:29 schrieb Peter Huewe:
> From: Peter Huewe <peterhuewe@gmx.de>
>
> Trivial patch which adds the __init and __exit macros to the module_init /
> module_exit functions from drivers/block/DAC960.c
> linux version 2.6.30
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>

Hi, 
@Jiri:
I was wondering if there is anything wrong with the patch or is it still in 
the review phase ?


Best Regards,
Peter

Re: [PATCH] block: adding __init/__exit macros to DAC960.c

[Jiri Kosina]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 376 bytes --]

On Tue, 23 Jun 2009, Peter Hüwe wrote:

> > Trivial patch which adds the __init and __exit macros to the module_init /
> > module_exit functions from drivers/block/DAC960.c
> > linux version 2.6.30
> I was wondering if there is anything wrong with the patch or is it still in 
> the review phase ?

I have applied it to trivial queue, thanks Peter.

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] block: adding __init/__exit macros to DAC960.c

[Peter Hüwe]

Am Dienstag 23 Juni 2009 10:48:28 schrieb Jiri Kosina:
> On Tue, 23 Jun 2009, Peter Hüwe wrote:
> > > Trivial patch which adds the __init and __exit macros to the
> > > module_init / module_exit functions from drivers/block/DAC960.c
> > > linux version 2.6.30
> >
> > I was wondering if there is anything wrong with the patch or is it still
> > in the review phase ?
>
> I have applied it to trivial queue, thanks Peter.

Hi Jiri,

I just looked in your git tree - it still does not appear there :)
I'm sorry for bugging you with this trivial patch.

Peter

Re: [PATCH] block: adding __init/__exit macros to DAC960.c

[Jiri Kosina]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 723 bytes --]

On Wed, 1 Jul 2009, Peter Hüwe wrote:

> > > > Trivial patch which adds the __init and __exit macros to the 
> > > > module_init / module_exit functions from drivers/block/DAC960.c 
> > > > linux version 2.6.30
> > > I was wondering if there is anything wrong with the patch or is it still
> > > in the review phase ?
> > I have applied it to trivial queue, thanks Peter.
> I just looked in your git tree - it still does not appear there :)
> I'm sorry for bugging you with this trivial patch.

Hi Peter,

I guess you looked into the wrong branch -- it is in 'for-next' branch, 
see 
http://git.kernel.org/?p=linux/kernel/git/jikos/trivial.git;a=commit;h=ef59a28cbb29dd6ec4fcd59eaacb15ea85adbd2e

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] block: adding __init/__exit macros to DAC960.c

[Peter Hüwe]

Am Mittwoch 01 Juli 2009 10:58:46 schrieb Jiri Kosina:
> On Wed, 1 Jul 2009, Peter Hüwe wrote:
> Hi Peter,
>
> I guess you looked into the wrong branch -- it is in 'for-next' branch,
> see
> http://git.kernel.org/?p=linux/kernel/git/jikos/trivial.git;a=commit;h=ef59
>a28cbb29dd6ec4fcd59eaacb15ea85adbd2e


Oh - my fault :) Seems I'm still not familiar enough with git :/
Thank you for the hint and merging my patch.

Thanks,
Peter