public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	hch@infradead.org
Subject: Re: merging the per-bdi writeback patchset
Date: Tue, 23 Jun 2009 01:48:35 -0700	[thread overview]
Message-ID: <20090623014835.1fc8fb14.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090623081156.GT31415@kernel.dk>

On Tue, 23 Jun 2009 10:11:56 +0200 Jens Axboe <jens.axboe@oracle.com> wrote:

> Things are looking good for this patchset and it's been in -next for
> almost a week without any reports of problems. So I'd like to merge it
> for 2.6.31 if at all possible. Any objections?

erk.  I was rather expecting I'd have time to have a look at it all.

It's unclear to me actually _why_ the performance changes which were
observed have actually occurred.  In fact it's a bit unclear (to me)
why the patchset was written and what it sets out to achieve :(

A long time ago the XFS guys (Dave Chinner iirc) said that XFS needs
more than one thread per device to keep the device saturated.  Did that
get addressed?

(kthread_run() returns an ERR_PTR() on error, btw - not NULL.)


  reply	other threads:[~2009-06-23  8:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-23  8:11 merging the per-bdi writeback patchset Jens Axboe
2009-06-23  8:48 ` Andrew Morton [this message]
2009-06-23  8:55   ` Jens Axboe
2009-06-23 10:28     ` KOSAKI Motohiro
2009-06-23 10:56       ` Jens Axboe
2009-06-23 11:19         ` KOSAKI Motohiro
2009-06-23 11:28           ` Jens Axboe
2009-06-23 11:44             ` KOSAKI Motohiro
2009-06-23 15:01     ` Andrew Morton
2009-06-24 10:04       ` Jens Axboe
2009-06-23 11:09 ` Christoph Hellwig
2009-06-23 11:12   ` Jens Axboe
2009-06-23 11:17     ` Christoph Hellwig
2009-06-23 11:52       ` Jens Axboe
2009-06-23 12:20         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090623014835.1fc8fb14.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox