From: Frans Pop <elendil@planet.nl>
To: David Miller <davem@davemloft.net>
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cs5520: add missing IRQ setup for the second port
Date: Tue, 23 Jun 2009 01:58:11 +0200 [thread overview]
Message-ID: <200906230158.12805.elendil@planet.nl> (raw)
In-Reply-To: <20090622.163136.246300819.davem@davemloft.net>
David Miller wrote:
> ide_pci_setup_ports() would loop over the available ports, one
> by one, recording IRQ numbers increasingly from the one passed
> in as "pciirq".
I looked at the commit and at the code and called functions several times
(just out of curiosity), but have been completely unable to find where
that increase of pciirq actually happened.
AFAICT ide_pci_setup_ports() just passed it on to ide_hw_configure() and
all that did was 'hw->irq = irq', so AFAICT in the old case both ports
would get the *same* IRQ, and not consecutive ones.
Am I missing something here?
next prev parent reply other threads:[~2009-06-22 23:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 11:48 [PATCH] cs5520: add missing IRQ setup for the second port Bartlomiej Zolnierkiewicz
2009-06-22 23:31 ` David Miller
2009-06-22 23:58 ` Frans Pop [this message]
2009-06-23 8:42 ` Alan Cox
2009-06-23 9:59 ` Bartlomiej Zolnierkiewicz
2009-06-23 15:33 ` Alan Cox
2009-06-23 23:44 ` David Miller
2009-06-24 9:22 ` Alan Cox
2009-06-24 9:36 ` David Miller
2009-06-23 0:30 ` Bartlomiej Zolnierkiewicz
2009-06-23 1:05 ` Bartlomiej Zolnierkiewicz
2009-06-23 4:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906230158.12805.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox