From: Jesper Nilsson <Jesper.Nilsson@axis.com>
To: Tim Abbott <tabbott@MIT.EDU>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Anders Kaseorg <andersk@MIT.EDU>, Waseem Daher <wdaher@MIT.EDU>,
Denys Vlasenko <vda.linux@googlemail.com>,
Jeff Arnold <jbarnold@MIT.EDU>,
Mikael Starvik <mikael.starvik@axis.com>
Subject: Re: [PATCH] cris: use new macros for .data.init_task.
Date: Tue, 23 Jun 2009 11:06:14 +0200 [thread overview]
Message-ID: <20090623090614.GZ12383@axis.com> (raw)
In-Reply-To: <1241135077-8001-2-git-send-email-tabbott@mit.edu>
On Fri, May 01, 2009 at 01:44:37AM +0200, Tim Abbott wrote:
> .data.init_task should not need a separate output section; this change
> moves it into the .data section.
Hi,
Sorry about not picking this up earlier, but what's the status of
the prerequisite macros? From what I can see, the prerequisite for
the first part of the patch is now in mainline, but there seems to
be no users of INIT_TASK_DATA yet.
(And it looks a bit dodgy as it uses INIT_TASK without any argument...)
Should I split up your patch or is there any reason to keep them together?
/Jesper
> Signed-off-by: Tim Abbott <tabbott@mit.edu>
> Cc: Mikael Starvik <starvik@axis.com>
> Cc: Jesper Nilsson <jesper.nilsson@axis.com>
> Cc: dev-etrax@axis.com
> ---
> arch/cris/kernel/process.c | 3 +--
> arch/cris/kernel/vmlinux.lds.S | 4 +---
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/cris/kernel/process.c b/arch/cris/kernel/process.c
> index 4df0b32..7a270c6 100644
> --- a/arch/cris/kernel/process.c
> +++ b/arch/cris/kernel/process.c
> @@ -49,8 +49,7 @@ EXPORT_SYMBOL(init_mm);
> * way process stacks are handled. This is done by having a special
> * "init_task" linker map entry..
> */
> -union thread_union init_thread_union
> - __attribute__((__section__(".data.init_task"))) =
> +union thread_union init_thread_union __init_task_data =
> { INIT_THREAD_INFO(init_task) };
>
> /*
> diff --git a/arch/cris/kernel/vmlinux.lds.S b/arch/cris/kernel/vmlinux.lds.S
> index 0d2adfc..e4f7490 100644
> --- a/arch/cris/kernel/vmlinux.lds.S
> +++ b/arch/cris/kernel/vmlinux.lds.S
> @@ -62,14 +62,12 @@ SECTIONS
> ___data_start = . ;
> __Sdata = . ;
> .data : { /* Data */
> + INIT_TASK_DATA(PAGE_SIZE)
> DATA_DATA
> }
> __edata = . ; /* End of data section. */
> _edata = . ;
>
> - . = ALIGN(PAGE_SIZE); /* init_task and stack, must be aligned. */
> - .data.init_task : { *(.data.init_task) }
> -
> . = ALIGN(PAGE_SIZE); /* Init code and data. */
> __init_begin = .;
> .init.text : {
> --
> 1.6.2.1
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2009-06-23 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 23:44 [PATCH] section name cleanup for cris Tim Abbott
2009-04-30 23:44 ` [PATCH] cris: use new macros for .data.init_task Tim Abbott
2009-06-23 9:06 ` Jesper Nilsson [this message]
2009-06-23 21:12 ` Sam Ravnborg
2009-06-23 22:53 ` [PATCH] Shuffle INIT_TASK* macro names in vmlinux.lds.h (was Re: [PATCH] cris: use new macros for .data.init_task.) Tim Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623090614.GZ12383@axis.com \
--to=jesper.nilsson@axis.com \
--cc=andersk@MIT.EDU \
--cc=jbarnold@MIT.EDU \
--cc=linux-kernel@vger.kernel.org \
--cc=mikael.starvik@axis.com \
--cc=sam@ravnborg.org \
--cc=tabbott@MIT.EDU \
--cc=vda.linux@googlemail.com \
--cc=wdaher@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox