From: Arnd Bergmann <arnd@arndb.de>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: [PATCH 2/2 v2] Blackfin: fix dma-mapping build errors
Date: Tue, 23 Jun 2009 10:40:46 +0200 [thread overview]
Message-ID: <200906231040.46767.arnd@arndb.de> (raw)
In-Reply-To: <1245724420-26317-1-git-send-email-vapier@gentoo.org>
On Tuesday 23 June 2009, Mike Frysinger wrote:
> +static inline void dma_sync_sg_for_device(struct device *dev,
> + struct scatterlist *sg,
> + int nents, enum dma_data_direction dir)
> +{
> +}
If you flush the dcache in dma_map_sg, you probably also need to
flush it in dma_sync_*_for_device:
static inline void
dma_sync_sg_for_device(struct device *dev, struct scatterlist *sglist,
int nents, enum dma_data_direction direction)
{
struct scatterlist *sg;
int i;
for_each_sg(sglist, sg, nents, i)
invalidate_dcache_range(sg_virt(sg), sg_virt(sg) + sg->length);
}
Arnd <><
next prev parent reply other threads:[~2009-06-23 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 1:54 [PATCH 1/2] Blackfin: hook up new perf_counter_open syscall Mike Frysinger
2009-06-23 1:54 ` [PATCH 2/2] Blackfin: fix dma-mapping build errors Mike Frysinger
2009-06-23 2:14 ` FUJITA Tomonori
2009-06-23 2:29 ` Mike Frysinger
2009-06-23 2:37 ` FUJITA Tomonori
2009-06-23 2:33 ` [PATCH 2/2 v2] " Mike Frysinger
2009-06-23 8:40 ` Arnd Bergmann [this message]
2009-06-23 11:09 ` Mike Frysinger
2009-06-23 13:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906231040.46767.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox