From: Dave Young <hidave.darkstar@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: + printk-boot_delay-rename-printk_delay_msec-to-loops_per_msec.patch added to -mm tree
Date: Tue, 23 Jun 2009 20:53:32 +0800 [thread overview]
Message-ID: <20090623125332.GD12135@darkstar> (raw)
In-Reply-To: <20090623072116.GC5747@elte.hu>
On Tue, Jun 23, 2009 at 09:21:16AM +0200, Ingo Molnar wrote:
>
> > +++ a/kernel/printk.c
> > @@ -198,12 +198,11 @@ __setup("log_buf_len=", log_buf_len_setu
> > #ifdef CONFIG_BOOT_PRINTK_DELAY
> >
> > static unsigned int boot_delay; /* msecs delay after each printk during bootup */
> > -static unsigned long long printk_delay_msec; /* per msec, based on boot_delay */
> > +static unsigned long long loops_per_msec;
>
> Lost a comment here - on purpose?
Yes, I thought loops_per_msec is clearer than printk_delay_msec for boot_delay, but add a comment is fine.
Andrew have fixed it, thanks.
>
> > - printk_delay_msec = loops_per_msec;
> > printk(KERN_DEBUG "boot_delay: %u, preset_lpj: %ld, lpj: %lu, "
> > - "HZ: %d, printk_delay_msec: %llu\n",
> > - boot_delay, preset_lpj, lpj, HZ, printk_delay_msec);
> > + "HZ: %d, loops_per_msec: %llu\n",
> > + boot_delay, preset_lpj, lpj, HZ, loops_per_msec);
>
> If you touch debug printks then please use pr_debug().
>
> Ingo
please see the following fix:
--
From: Dave Young <hidave.darkstar@gmail.com>
use pr_debug for debug printk.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
kernel/printk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.orig/kernel/printk.c 2009-06-23 17:48:25.000000000 +0800
+++ linux-2.6/kernel/printk.c 2009-06-23 18:08:18.000000000 +0800
@@ -211,7 +211,7 @@ static int __init boot_delay_setup(char
if (boot_delay > 10 * 1000)
boot_delay = 0;
- printk(KERN_DEBUG "boot_delay: %u, preset_lpj: %ld, lpj: %lu, "
+ pr_debug("boot_delay: %u, preset_lpj: %ld, lpj: %lu, "
"HZ: %d, loops_per_msec: %llu\n",
boot_delay, preset_lpj, lpj, HZ, loops_per_msec);
return 1;
prev parent reply other threads:[~2009-06-23 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200906230556.n5N5uG3a017246@imap1.linux-foundation.org>
2009-06-23 7:18 ` + printk-boot_delay-rename-printk_delay_msec-to-loops_per_msec.patch added to -mm tree Ingo Molnar
2009-06-23 7:21 ` Ingo Molnar
2009-06-23 12:53 ` Dave Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623125332.GD12135@darkstar \
--to=hidave.darkstar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox