From: Frans Pop <elendil@planet.nl>
To: David Miller <davem@davemloft.net>
Cc: bzolnier@gmail.com, sparclinux@vger.kernel.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide-cd: Improve "weird block size" error message
Date: Tue, 23 Jun 2009 13:13:53 +0200 [thread overview]
Message-ID: <200906231313.55057.elendil@planet.nl> (raw)
In-Reply-To: <20090623.035926.155211513.davem@davemloft.net>
On Tuesday 23 June 2009, David Miller wrote:
> Therefore, any objections to something like this?
>
> ide-cd: Don't warn on bogus block size unless it actually matters.
>
> Frans Pop reported that his CDROM drive reports a blocksize of 2352,
> and this causes new warnings due to commit
> e8e7b9eb11c34ee18bde8b7011af41938d1ad667 ("ide-cd: fix oops when using
> growisofs").
>
> What we're trying to do is make sure that "blocklen >> SECTOR_BITS"
> is something the block layer won't choke on.
>
> And for Frans case "2352 >> SECTOR_BITS" is equal to
> "2048 >> SECTOR_BITS", and thats "4".
So basically there's garbage in unused bits?
> So warning in this case gives no real benefit.
Fine by me. I'll be glad to be rid of that error :-)
I'll give your patch a try with my next build.
But I think my patch still makes sense for those cases where the original
error _does_ exist. Unless your patch fixes those as well, but we can't
know that for sure, can we?
next prev parent reply other threads:[~2009-06-23 11:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200906211446.38598.elendil@planet.nl>
[not found] ` <20090621.224510.96380426.davem@davemloft.net>
[not found] ` <200906220843.14337.elendil@planet.nl>
2009-06-22 11:21 ` cmd64x: irq 14: nobody cared - system is dreadfully slow Bartlomiej Zolnierkiewicz
2009-06-22 14:04 ` Frans Pop
2009-06-22 14:39 ` Bartlomiej Zolnierkiewicz
2009-06-22 15:16 ` Frans Pop
2009-06-22 17:38 ` Bartlomiej Zolnierkiewicz
2009-06-22 19:01 ` Frans Pop
2009-06-22 21:35 ` Bartlomiej Zolnierkiewicz
2009-06-23 7:51 ` [PATCH] ide-cd: Improve "weird block size" error message Frans Pop
2009-06-23 7:57 ` Borislav Petkov
2009-06-23 8:02 ` Borislav Petkov
2009-06-23 23:03 ` David Miller
2009-06-23 8:20 ` Frans Pop
2009-06-23 10:59 ` David Miller
2009-06-23 11:13 ` Frans Pop [this message]
2009-06-23 11:18 ` David Miller
2009-06-23 21:30 ` Frans Pop
2009-06-23 23:01 ` David Miller
2009-06-29 11:19 ` Jan Engelhardt
2009-06-23 10:15 ` cmd64x: irq 14: nobody cared - system is dreadfully slow David Miller
2009-06-23 14:58 ` Frans Pop
2009-06-23 16:13 ` Bartlomiej Zolnierkiewicz
2009-06-23 23:04 ` David Miller
2009-06-23 10:47 ` David Miller
2009-06-23 10:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906231313.55057.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox