public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
	rgetz@blackfin.uclinux.org
Subject: Re: [PATCH 1/4] asm/sections: add text/data checking functions for arches to override
Date: Tue, 23 Jun 2009 15:40:22 -0700	[thread overview]
Message-ID: <20090623154022.61e83c33.akpm@linux-foundation.org> (raw)
In-Reply-To: <1245255744-21039-1-git-send-email-vapier@gentoo.org>

On Wed, 17 Jun 2009 12:22:21 -0400
Mike Frysinger <vapier@gentoo.org> wrote:

> Some ports (like the Blackfin arch) have a discontiguous memory map which
> means there may be text or data that falls outside of the standard range
> of the start/end text/data symbols.  Creating some helper functions allows
> these non-standard ports to declare these regions without adversely
> affecting anyone else.
> 

The patches look OK to me.

I assumed they're for 2.6.32.

> index 4ce48e8..ee19462 100644
> --- a/include/asm-generic/sections.h
> +++ b/include/asm-generic/sections.h
> @@ -20,4 +20,20 @@ extern char __start_rodata[], __end_rodata[];
>  #define dereference_function_descriptor(p) (p)
>  #endif
>  
> +/* random extra sections (if any).  Override
> + * in asm/sections.h */
> +#ifndef arch_is_kernel_text
> +static inline int arch_is_kernel_text(unsigned long addr)
> +{
> +	return 0;
> +}
> +#endif
> +
> +#ifndef arch_is_kernel_data
> +static inline int arch_is_kernel_data(unsigned long addr)
> +{
> +	return 0;
> +}
> +#endif

I suppose that for completeness and consistency etc really we should have

#define arch_is_kernel_text arch_is_kernel_text
#define arch_is_kernel_data arch_is_kernel_data

in here.

  parent reply	other threads:[~2009-06-23 22:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-17 16:22 [PATCH 1/4] asm/sections: add text/data checking functions for arches to override Mike Frysinger
2009-06-17 16:22 ` [PATCH 2/4] kallsyms: use new arch_is_kernel_text() Mike Frysinger
2009-06-17 16:22 ` [PATCH 3/4] lockdep: use new arch_is_kernel_data() Mike Frysinger
2009-06-17 16:22 ` [PATCH 4/4] Blackfin: override text/data checking functions Mike Frysinger
2009-06-23 22:40 ` Andrew Morton [this message]
2009-06-24  1:48   ` [PATCH 1/4] asm/sections: add text/data checking functions for arches to override Mike Frysinger
2009-06-24  2:04     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090623154022.61e83c33.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rgetz@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox