From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf stat: fix hardcoded nr_counter
Date: Wed, 24 Jun 2009 10:58:12 +0200 [thread overview]
Message-ID: <20090624085812.GD18713@elte.hu> (raw)
In-Reply-To: <1245810296.3434.3.camel@ht.satnam>
* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> nr_counter should be based on number of default_attrs entries.
The problem is, this will cause a _lot_ of counters to be used by
default, overloading the PMU quite significantly and reducing
precision. The number of hw counters is chosen intentionally the way
it is now, so that on common hardware there's no over-commit.
As i suggested before, your change does make sense if introduced as
extended event specifications to 'perf stat':
-e all
-e all-sw-counters
-e all-hw-counters
with regex wildcard support too.
Instead, you chose to ignore my feedback and wasted my time by
re-sending the same broken patch. If you do such things i'll have to
start ignoring you - it is very ineffective for me to repeat every
argument and suggestion two or more times and no other contributor
does this ...
> Remove dead code and some code alignment.
Could you please send this separately?
Ingo
next prev parent reply other threads:[~2009-06-24 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 2:24 [PATCH] perf stat: fix hardcoded nr_counter Jaswinder Singh Rajput
2009-06-24 8:58 ` Ingo Molnar [this message]
2009-06-24 12:56 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090624085812.GD18713@elte.hu \
--to=mingo@elte.hu \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox