From: Ingo Molnar <mingo@elte.hu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Liming Wang <liming.wang@windriver.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/7] tracing: seqfile fixes, take 2
Date: Wed, 24 Jun 2009 11:03:58 +0200 [thread overview]
Message-ID: <20090624090358.GA25212@elte.hu> (raw)
In-Reply-To: <4A4186C6.9090706@cn.fujitsu.com>
* Li Zefan <lizf@cn.fujitsu.com> wrote:
> While testing syscall tracepoints proposed by Jason, I found some
> entries were missing when reading available_events.
>
> It turned out there's bug in seqfile handling. The bug is, it's
> wrong to increment @pos in seq start().
>
> The bug exists in some other places. I also fixed some other different
> bugs.
>
> All the patches have been reviewed and tested.
>
> Thanks Liming Wang for the review.
>
> [PATCH 1/7] tracing/events: don't increment @pos in s_start()
> [PATCH 2/7] tracing_bprintk: don't increment @pos in t_start()
> [PATCH 3/7] trace_stat: don't increment @pos in seq start()
> [PATCH 4/7] tracing: reset iterator in t_start()
> [PATCH 5/7] ftrace: don't increment @pos in g_start()
> [PATCH 6/7] ftrace: don't manipulate @pos in t_start()
> [PATCH 7/7] ftrace: fix t_hash_start()
> ---
> kernel/trace/ftrace.c | 52 ++++++++++++++++++++++++-------------------
> kernel/trace/trace.c | 18 +++-----------
> kernel/trace/trace_events.c | 28 ++++++++++++++++++-----
> kernel/trace/trace_printk.c | 26 +++++----------------
> kernel/trace/trace_stat.c | 6 +----
> 5 files changed, 62 insertions(+), 68 deletions(-)
Applied to tip:tracing/urgent, thanks a lot!
Ingo
prev parent reply other threads:[~2009-06-24 9:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 1:52 [PATCH 0/7] tracing: seqfile fixes, take 2 Li Zefan
2009-06-24 1:52 ` [PATCH 1/7] tracing/events: don't increment @pos in s_start() Li Zefan
2009-06-24 9:45 ` [tip:tracing/urgent] tracing/events: Don't " tip-bot for Li Zefan
2009-06-24 1:52 ` [PATCH 2/7] tracing_bprintk: don't increment @pos in t_start() Li Zefan
2009-06-24 9:45 ` [tip:tracing/urgent] tracing_bprintk: Don't " tip-bot for Li Zefan
2009-06-24 1:53 ` [PATCH 3/7] trace_stat: don't increment @pos in seq start() Li Zefan
2009-06-24 9:46 ` [tip:tracing/urgent] trace_stat: Don't " tip-bot for Li Zefan
2009-06-24 1:53 ` [PATCH 4/7] tracing: reset iterator in t_start() Li Zefan
2009-06-24 9:46 ` [tip:tracing/urgent] tracing: Reset " tip-bot for Li Zefan
2009-06-24 1:54 ` [PATCH 5/7] ftrace: don't increment @pos in g_start() Li Zefan
2009-06-24 9:46 ` [tip:tracing/urgent] ftrace: Don't " tip-bot for Li Zefan
2009-06-24 1:54 ` [PATCH 6/7] ftrace: don't manipulate @pos in t_start() Li Zefan
2009-06-24 9:46 ` [tip:tracing/urgent] ftrace: Don't " tip-bot for Li Zefan
2009-06-24 1:54 ` [PATCH 7/7] ftrace: fix t_hash_start() Li Zefan
2009-06-24 9:46 ` [tip:tracing/urgent] ftrace: Fix t_hash_start() tip-bot for Li Zefan
2009-06-24 9:03 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090624090358.GA25212@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=liming.wang@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox