Re: [patch 2/6] ide: fix ide_kill_rq() for special ide-{floppy,tape} driver requests

Borislav Petkov
2009-06-24T07:08:29Z

On Tue, Jun 23, 2009 at 04:16:11PM -0700, David Miller wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Date: Tue, 23 Jun 2009 23:26:06 +0200
>
> > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Subject: [PATCH] ide: fix ide_kill_rq() for special ide-{floppy,tape} driver requests
> >
> > Such requests should be failed with -EIO (like all other requests
> > in this function) instead of being completed successfully.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > ---
> > Untested, you may try pinging Borislav and/or Tejun about possible
> > testing if you would like to verify the patch before applying.
>
> This must be tested in some way. I can see this potentially
> breaking something.
>
> Especially this is true because ide_complete_rq() does it's
> "complete whole request right now" logic for error <= 0.
>
> Borislov/Tejun, can either of you test this code path with this
> change applied? I'd very much appreciate it.

Yep, I'll give the whole series a whirl in a while.

--
Regards/Gruss,
Boris.